From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7796 invoked by alias); 17 May 2010 17:28:15 -0000 Received: (qmail 7697 invoked by uid 22791); 17 May 2010 17:28:14 -0000 X-SWARE-Spam-Status: No, hits=-2.1 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 17 May 2010 17:28:05 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 805C32BABF2; Mon, 17 May 2010 13:28:03 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id oa225mvRhU6T; Mon, 17 May 2010 13:28:03 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id BD6672BAC13; Mon, 17 May 2010 13:28:02 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id 99EE3F58F9; Mon, 17 May 2010 19:27:58 +0200 (CEST) Date: Mon, 17 May 2010 17:34:00 -0000 From: Joel Brobecker To: Tom Tromey Cc: Pierre Muller , gdb-patches@sourceware.org Subject: Re: [RFA] dwarf debug format: Support DW_AT_variable_parameter attribute Message-ID: <20100517172758.GJ2805@adacore.com> References: <8830.7035308846$1273670829@news.gmane.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.20 (2009-06-14) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-05/txt/msg00359.txt.bz2 > Pierre> Should zero be considered as FALSE and > Pierre> thus the should say that this parameter is NOT a variable parameter, > Pierre> or does the simple presence of this attribute condfirm > Pierre> this it is a variable parameter, no matter the value of the flag. > Pierre> I took the first approach here, but have the impression > Pierre> that it is not always the case inside dwarf2read.c code. > > I think you made the correct choice. FWIW: I also double-checked the DWARF3 standard, and it says that the value of this attribute is a flag, and following the hyperlinks in the PDF, one gets to: flag A flag is represented as a single byte of data (DW_FORM_flag). If the flag has value zero, it indicates the absence of the attribute. If the flag has a non-zero value, it indicates the presence of the attribute. -- Joel