Re: [RFA] dwarf debug format: Support DW_AT_variable_parameter attribute

Tom Tromey
2010-05-13T17:29:14Z

>>>>> "Pierre" == Pierre Muller <pierre.muller@ics-cnrs.unistra.fr> writes:

Pierre> Free Pascal compiler has support for
Pierre> DW_AT_variable_parameter attribute, but this is disabled because
Pierre> GDB does not support it yet.

Pierre> The value of the attribute must be a flag according to
Pierre> DWARF specs. The only point I am unsure about is
Pierre> what does a zero value of this flag mean:
Pierre> Should zero be considered as FALSE and
Pierre> thus the should say that this parameter is NOT a variable parameter,
Pierre> or does the simple presence of this attribute condfirm
Pierre> this it is a variable parameter, no matter the value of the flag.
Pierre> I took the first approach here, but have the impression
Pierre> that it is not always the case inside dwarf2read.c code.

I think you made the correct choice.

Pierre> Is this OK?

I wonder whether it is possible for such a parameter to be marked as
LOC_COMPUTED or LOC_OPTIMIZED_OUT by var_decode_location. If so then
changing the class to LOC_REF_ARG seems incorrect.

Tom