From: Tom Tromey <tromey@redhat.com>
To: "Pierre Muller" <pierre.muller@ics-cnrs.unistra.fr>
Cc: "'Joel Brobecker'" <brobecker@adacore.com>,
<gdb-patches@sourceware.org>,
"'FPC Core Developer List'" <core@freepascal.org>
Subject: Re: [RFA] dwarf debug format: Support DW_AT_variable_parameter attribute
Date: Wed, 19 May 2010 19:43:00 -0000 [thread overview]
Message-ID: <m3fx1n90ul.fsf@fleche.redhat.com> (raw)
In-Reply-To: <44296.7587885962$1274132782@news.gmane.org> (Pierre Muller's message of "Mon, 17 May 2010 23:45:26 +0200")
>>>>> "Pierre" == Pierre Muller <pierre.muller@ics-cnrs.unistra.fr> writes:
Pierre> I looked a little more into the sources
Pierre> and now understand that my patch is indeed
Pierre> wrong :(
[...]
Pierre> See note line 8459 from dwarf2read.c source.
Pierre> /* NOTE drow/2002-01-30: It might be worthwhile to have a static
Pierre> expression evaluator, and use LOC_COMPUTED only when necessary
Pierre> (i.e. when the value of a register or memory location is
Pierre> referenced, or a thread-local block, etc.). Then again, it might
Pierre> not be worthwhile. I'm assuming that it isn't unless performance
Pierre> or memory numbers show me otherwise. */
Pierre> I fear that my patch will have to wait until
Pierre> this static expression evaluator is implemented...
I'm not totally convinced that we would want such an evaluator.
Could you change the type of a parameter marked with
DW_AT_variable_parameter to be a reference type instead? It seems to me
that this would give the same result, or nearly so.
Tom
next prev parent reply other threads:[~2010-05-19 18:57 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <8830.7035308846$1273670829@news.gmane.org>
2010-05-13 17:51 ` Tom Tromey
2010-05-17 17:34 ` Joel Brobecker
2010-05-17 17:34 ` Pierre Muller
2010-05-17 18:54 ` Joel Brobecker
2010-05-17 21:48 ` Pierre Muller
[not found] ` <44296.7587885962$1274132782@news.gmane.org>
2010-05-19 19:43 ` Tom Tromey [this message]
2010-05-19 21:45 ` Pierre Muller
[not found] ` <28559.2589797036$1274302480@news.gmane.org>
2010-05-19 22:34 ` Tom Tromey
2010-05-19 23:34 ` [RFA-v2] " Pierre Muller
[not found] ` <27418.1569614031$1274308493@news.gmane.org>
2010-05-21 17:44 ` Tom Tromey
2010-05-21 20:50 ` Pierre Muller
2010-11-04 5:32 ` [new testcase] Regression 7.1->7.2 for iFort [Re: [RFA-v2] dwarf debug format: Support DW_AT_variable_parameter attribute] Jan Kratochvil
2010-11-04 8:47 ` [Core] " Pierre Free Pascal
2010-11-04 18:01 ` Joel Brobecker
2010-11-05 8:04 ` Pierre Free Pascal
2011-09-01 7:20 ` Jan Kratochvil
2010-05-12 13:27 [RFA] dwarf debug format: Support DW_AT_variable_parameter attribute Pierre Muller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3fx1n90ul.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=brobecker@adacore.com \
--cc=core@freepascal.org \
--cc=gdb-patches@sourceware.org \
--cc=pierre.muller@ics-cnrs.unistra.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox