Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Mark Kettenis <mark.kettenis@xs4all.nl>
To: hjl.tools@gmail.com
Cc: gdb-patches@sourceware.org, jan.kratochvil@redhat.com
Subject: Re: PATCH: PR corefiles/11467: amd64 gdb generates corrupted 32bit  	core file
Date: Tue, 13 Apr 2010 18:43:00 -0000	[thread overview]
Message-ID: <201004131842.o3DIgnb7005998@glazunov.sibelius.xs4all.nl> (raw)
In-Reply-To: <m2t6dc9ffc81004131039wee0aa66fk4964427291611b52@mail.gmail.com> 	(hjl.tools@gmail.com)

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain, Size: 1230 bytes --]

> Date: Tue, 13 Apr 2010 10:39:24 -0700
> From: "H.J. Lu" <hjl.tools@gmail.com>
> 
> On Tue, Apr 13, 2010 at 10:26 AM, Mark Kettenis <mark.kettenis@xs4all.nl> wrote:
> >> Date: Tue, 13 Apr 2010 10:17:57 -0700
> >> From: "H.J. Lu" <hongjiu.lu@intel.com>
> >>
> >> On Mon, Apr 12, 2010 at 06:22:25AM -0700, H.J. Lu wrote:
> >> > On Sun, Apr 11, 2010 at 01:52:50PM -0700, H.J. Lu wrote:
> >> > > Hi,
> >> > >
> >> > > Thanks for Mark's pointer. Solution is very simple. We just need to
> >> > > make sure that we call the right fill_gregset for 32bit executable
> >> > > on both Linux/x86-64 and Linux/i386.  OK to install?
> >> > >
> >> > > Thanks.
> >> > >
> >> > >
> >> >
> >> > Small update to use tdep->gregset_reg_offset instead of
> >> > i386_linux_gregset_reg_offset.  OK to install?
> >> >
> >>
> >>
> >> Here is the updated patch. It calls set_gdbarch_regset_from_core_section
> >> with i386_linux_regset_from_core_section.  OK to install?
> >
> >
> > Sorry, no.  You're adding far too much bloat.
> >
> 
> Can you be more specific?

Yup; sent an explanation as a reply to one of your earlier mail.  Just
wanted to make sure you didn't dig yourself an even bigger hole while
I was looking at some of the details here.


  reply	other threads:[~2010-04-13 18:43 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-04-10 22:19 H.J. Lu
2010-04-10 22:27 ` H.J. Lu
2010-04-11  0:01   ` H.J. Lu
2010-04-11 20:53     ` H.J. Lu
2010-04-12 13:22       ` H.J. Lu
2010-04-12 18:24         ` Mark Kettenis
2010-04-12 18:50           ` H.J. Lu
2010-04-13 18:40             ` Mark Kettenis
2010-04-13 19:19               ` H.J. Lu
2010-04-13 20:03               ` H.J. Lu
2010-04-13 17:18         ` H.J. Lu
2010-04-13 17:27           ` Mark Kettenis
2010-04-13 17:39             ` H.J. Lu
2010-04-13 18:43               ` Mark Kettenis [this message]
2010-04-13 17:48           ` H.J. Lu
2010-04-13 20:38             ` H.J. Lu
2010-04-13 20:48               ` Mark Kettenis
2010-04-11 16:50   ` Mark Kettenis
2010-04-11 17:33     ` H.J. Lu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201004131842.o3DIgnb7005998@glazunov.sibelius.xs4all.nl \
    --to=mark.kettenis@xs4all.nl \
    --cc=gdb-patches@sourceware.org \
    --cc=hjl.tools@gmail.com \
    --cc=jan.kratochvil@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox