From: "H.J. Lu" <hjl.tools@gmail.com>
To: Mark Kettenis <mark.kettenis@xs4all.nl>
Cc: gdb-patches@sourceware.org, jan.kratochvil@redhat.com
Subject: Re: PATCH: PR corefiles/11467: amd64 gdb generates corrupted 32bit core file
Date: Tue, 13 Apr 2010 20:03:00 -0000 [thread overview]
Message-ID: <y2z6dc9ffc81004131303j11cf309bpdfe2090db7ff2314@mail.gmail.com> (raw)
In-Reply-To: <201004131840.o3DIeDo9001302@glazunov.sibelius.xs4all.nl>
On Tue, Apr 13, 2010 at 11:40 AM, Mark Kettenis <mark.kettenis@xs4all.nl> wrote:
>
> Anyway, there is a somewhat fundamental flaw in
> linux-nat.c:linux_nat_do_thread_registers() in that it always passes
> the size of 64-bit version of gregset_t in the
> gdbarch_regset_from_core_section() call. That's wrong, and probably
> the ultimate reason why the 64x32 gcore case isn't working properly.
>
That is problematic. For GP registers, total size of GP registers
may not be the size of the note section of GP registers. So we
can't use that section size. For x86, we can use
size >= tdep->sizeof_gregset
with a comment saying something like "size of 64bit version
of gregset_t may be passed down."
--
H.J.
next prev parent reply other threads:[~2010-04-13 20:03 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-10 22:19 H.J. Lu
2010-04-10 22:27 ` H.J. Lu
2010-04-11 0:01 ` H.J. Lu
2010-04-11 20:53 ` H.J. Lu
2010-04-12 13:22 ` H.J. Lu
2010-04-12 18:24 ` Mark Kettenis
2010-04-12 18:50 ` H.J. Lu
2010-04-13 18:40 ` Mark Kettenis
2010-04-13 19:19 ` H.J. Lu
2010-04-13 20:03 ` H.J. Lu [this message]
2010-04-13 17:18 ` H.J. Lu
2010-04-13 17:27 ` Mark Kettenis
2010-04-13 17:39 ` H.J. Lu
2010-04-13 18:43 ` Mark Kettenis
2010-04-13 17:48 ` H.J. Lu
2010-04-13 20:38 ` H.J. Lu
2010-04-13 20:48 ` Mark Kettenis
2010-04-11 16:50 ` Mark Kettenis
2010-04-11 17:33 ` H.J. Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=y2z6dc9ffc81004131303j11cf309bpdfe2090db7ff2314@mail.gmail.com \
--to=hjl.tools@gmail.com \
--cc=gdb-patches@sourceware.org \
--cc=jan.kratochvil@redhat.com \
--cc=mark.kettenis@xs4all.nl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox