Re: PATCH: PR corefiles/11467: amd64 gdb generates corrupted 32bit core file

["H.J. Lu" <hjl.tools@gmail.com>]

On Tue, Apr 13, 2010 at 10:26 AM, Mark Kettenis <mark.kettenis@xs4all.nl> wrote:
>> Date: Tue, 13 Apr 2010 10:17:57 -0700
>> From: "H.J. Lu" <hongjiu.lu@intel.com>
>>
>> On Mon, Apr 12, 2010 at 06:22:25AM -0700, H.J. Lu wrote:
>> > On Sun, Apr 11, 2010 at 01:52:50PM -0700, H.J. Lu wrote:
>> > > Hi,
>> > >
>> > > Thanks for Mark's pointer. Solution is very simple. We just need to
>> > > make sure that we call the right fill_gregset for 32bit executable
>> > > on both Linux/x86-64 and Linux/i386.  OK to install?
>> > >
>> > > Thanks.
>> > >
>> > >
>> >
>> > Small update to use tdep->gregset_reg_offset instead of
>> > i386_linux_gregset_reg_offset.  OK to install?
>> >
>>
>>
>> Here is the updated patch. It calls set_gdbarch_regset_from_core_section
>> with i386_linux_regset_from_core_section.  OK to install?
>
>
> Sorry, no.  You're adding far too much bloat.
>

Can you be more specific?

I added i386_linux_supply_gregset, i386_linux_collect_gregset
and i386_linux_regset_from_core_section because the the
size check on general purpose registers:

if (strcmp (sect_name, ".reg") == 0 && sect_size == tdep->sizeof_gregset)

and

gdb_assert (len == tdep->sizeof_gregset);

They are always false on Linux. I suspect that they are also false
on most other x86 OSes. But I can't verify it.

If it can be removed, many changes in my patch wont' be needed.

Thanks.

-- 
H.J.