From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29817 invoked by alias); 13 Apr 2010 18:43:12 -0000 Received: (qmail 29808 invoked by uid 22791); 13 Apr 2010 18:43:12 -0000 X-SWARE-Spam-Status: No, hits=-1.9 required=5.0 tests=BAYES_00,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from sibelius.xs4all.nl (HELO glazunov.sibelius.xs4all.nl) (83.163.83.176) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 13 Apr 2010 18:43:07 +0000 Received: from glazunov.sibelius.xs4all.nl (kettenis@localhost [127.0.0.1]) by glazunov.sibelius.xs4all.nl (8.14.3/8.14.3) with ESMTP id o3DIgoFL023053; Tue, 13 Apr 2010 20:42:50 +0200 (CEST) Received: (from kettenis@localhost) by glazunov.sibelius.xs4all.nl (8.14.3/8.14.3/Submit) id o3DIgnb7005998; Tue, 13 Apr 2010 20:42:49 +0200 (CEST) Date: Tue, 13 Apr 2010 18:43:00 -0000 Message-Id: <201004131842.o3DIgnb7005998@glazunov.sibelius.xs4all.nl> From: Mark Kettenis To: hjl.tools@gmail.com CC: gdb-patches@sourceware.org, jan.kratochvil@redhat.com In-reply-to: (hjl.tools@gmail.com) Subject: Re: PATCH: PR corefiles/11467: amd64 gdb generates corrupted 32bit core file References: <20100410221943.GA9675@intel.com> <20100410222742.GA9901@intel.com> <20100411000053.GA12675@intel.com> <20100411205250.GA24158@intel.com> <20100412132225.GA5932@intel.com> <20100413171757.GA6387@intel.com> <201004131726.o3DHQcQI025209@glazunov.sibelius.xs4all.nl> Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-04/txt/msg00420.txt.bz2 > Date: Tue, 13 Apr 2010 10:39:24 -0700 > From: "H.J. Lu" > > On Tue, Apr 13, 2010 at 10:26 AM, Mark Kettenis wrote: > >> Date: Tue, 13 Apr 2010 10:17:57 -0700 > >> From: "H.J. Lu" > >> > >> On Mon, Apr 12, 2010 at 06:22:25AM -0700, H.J. Lu wrote: > >> > On Sun, Apr 11, 2010 at 01:52:50PM -0700, H.J. Lu wrote: > >> > > Hi, > >> > > > >> > > Thanks for Mark's pointer. Solution is very simple. We just need to > >> > > make sure that we call the right fill_gregset for 32bit executable > >> > > on both Linux/x86-64 and Linux/i386.  OK to install? > >> > > > >> > > Thanks. > >> > > > >> > > > >> > > >> > Small update to use tdep->gregset_reg_offset instead of > >> > i386_linux_gregset_reg_offset.  OK to install? > >> > > >> > >> > >> Here is the updated patch. It calls set_gdbarch_regset_from_core_section > >> with i386_linux_regset_from_core_section.  OK to install? > > > > > > Sorry, no.  You're adding far too much bloat. > > > > Can you be more specific? Yup; sent an explanation as a reply to one of your earlier mail. Just wanted to make sure you didn't dig yourself an even bigger hole while I was looking at some of the details here.