* [patch] have sim-model.c include sim-model.h
@ 2010-02-04 7:09 Mike Frysinger
2010-02-04 21:39 ` Doug Evans
0 siblings, 1 reply; 2+ messages in thread
From: Mike Frysinger @ 2010-02-04 7:09 UTC (permalink / raw)
To: gdb-patches
[-- Attachment #1: Type: Text/Plain, Size: 873 bytes --]
the sim-model.c code obviously uses things from sim-model.h, but doesnt
explicitly include it. instead, it relies on sim-main.h to pull it in. when
doing a new port and building this file, the errors reported can be pretty
confusing. so pull in sim-model.h to make the process a bit smoother.
2010-02-04 Mike Frysinger <vapier@gentoo.org>
* sim-model.c: Include sim-model.h
RCS file: /cvs/src/src/sim/common/sim-model.c,v
retrieving revision 1.6
diff -u -p -r1.6 sim-model.c
--- sim/common/sim-model.c 1 Jan 2010 10:03:27 -0000 1.6
+++ sim/common/sim-model.c 4 Feb 2010 07:02:42 -0000
@@ -19,6 +19,7 @@ You should have received a copy of the G
along with this program. If not, see <http://www.gnu.org/licenses/>. */
#include "sim-main.h"
+#include "sim-model.h"
#include "libiberty.h"
#include "sim-options.h"
#include "sim-io.h"
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [patch] have sim-model.c include sim-model.h
2010-02-04 7:09 [patch] have sim-model.c include sim-model.h Mike Frysinger
@ 2010-02-04 21:39 ` Doug Evans
0 siblings, 0 replies; 2+ messages in thread
From: Doug Evans @ 2010-02-04 21:39 UTC (permalink / raw)
To: Mike Frysinger; +Cc: gdb-patches
On Wed, Feb 3, 2010 at 11:09 PM, Mike Frysinger <vapier@gentoo.org> wrote:
> the sim-model.c code obviously uses things from sim-model.h, but doesnt
> explicitly include it. instead, it relies on sim-main.h to pull it in. when
> doing a new port and building this file, the errors reported can be pretty
> confusing. so pull in sim-model.h to make the process a bit smoother.
>
> 2010-02-04 Mike Frysinger <vapier@gentoo.org>
>
> * sim-model.c: Include sim-model.h
>
> RCS file: /cvs/src/src/sim/common/sim-model.c,v
> retrieving revision 1.6
> diff -u -p -r1.6 sim-model.c
> --- sim/common/sim-model.c 1 Jan 2010 10:03:27 -0000 1.6
> +++ sim/common/sim-model.c 4 Feb 2010 07:02:42 -0000
> @@ -19,6 +19,7 @@ You should have received a copy of the G
> along with this program. If not, see <http://www.gnu.org/licenses/>. */
>
> #include "sim-main.h"
> +#include "sim-model.h"
> #include "libiberty.h"
> #include "sim-options.h"
> #include "sim-io.h"
>
Hi. This patch is ok with me. Thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-02-04 21:39 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-02-04 7:09 [patch] have sim-model.c include sim-model.h Mike Frysinger
2010-02-04 21:39 ` Doug Evans
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox