From: Doug Evans <dje@google.com>
To: Mike Frysinger <vapier@gentoo.org>
Cc: gdb-patches@sourceware.org
Subject: Re: [patch] have sim-model.c include sim-model.h
Date: Thu, 04 Feb 2010 21:39:00 -0000 [thread overview]
Message-ID: <e394668d1002041339q3c6afd64ic1d792c9559249eb@mail.gmail.com> (raw)
In-Reply-To: <201002040209.28922.vapier@gentoo.org>
On Wed, Feb 3, 2010 at 11:09 PM, Mike Frysinger <vapier@gentoo.org> wrote:
> the sim-model.c code obviously uses things from sim-model.h, but doesnt
> explicitly include it. instead, it relies on sim-main.h to pull it in. when
> doing a new port and building this file, the errors reported can be pretty
> confusing. so pull in sim-model.h to make the process a bit smoother.
>
> 2010-02-04 Mike Frysinger <vapier@gentoo.org>
>
> * sim-model.c: Include sim-model.h
>
> RCS file: /cvs/src/src/sim/common/sim-model.c,v
> retrieving revision 1.6
> diff -u -p -r1.6 sim-model.c
> --- sim/common/sim-model.c 1 Jan 2010 10:03:27 -0000 1.6
> +++ sim/common/sim-model.c 4 Feb 2010 07:02:42 -0000
> @@ -19,6 +19,7 @@ You should have received a copy of the G
> along with this program. If not, see <http://www.gnu.org/licenses/>. */
>
> #include "sim-main.h"
> +#include "sim-model.h"
> #include "libiberty.h"
> #include "sim-options.h"
> #include "sim-io.h"
>
Hi. This patch is ok with me. Thanks.
prev parent reply other threads:[~2010-02-04 21:39 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-04 7:09 Mike Frysinger
2010-02-04 21:39 ` Doug Evans [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e394668d1002041339q3c6afd64ic1d792c9559249eb@mail.gmail.com \
--to=dje@google.com \
--cc=gdb-patches@sourceware.org \
--cc=vapier@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox