From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12383 invoked by alias); 4 Feb 2010 21:39:59 -0000 Received: (qmail 12372 invoked by uid 22791); 4 Feb 2010 21:39:58 -0000 X-SWARE-Spam-Status: No, hits=-1.9 required=5.0 tests=AWL,BAYES_00,SARE_MSGID_LONG40,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: sourceware.org Received: from smtp-out.google.com (HELO smtp-out.google.com) (216.239.33.17) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 04 Feb 2010 21:39:53 +0000 Received: from wpaz29.hot.corp.google.com (wpaz29.hot.corp.google.com [172.24.198.93]) by smtp-out.google.com with ESMTP id o14Ldnhg005562 for ; Thu, 4 Feb 2010 21:39:50 GMT Received: from fg-out-1718.google.com (fgae21.prod.google.com [10.86.56.21]) by wpaz29.hot.corp.google.com with ESMTP id o14LdRla011586 for ; Thu, 4 Feb 2010 13:39:48 -0800 Received: by fg-out-1718.google.com with SMTP id e21so80511fga.6 for ; Thu, 04 Feb 2010 13:39:48 -0800 (PST) MIME-Version: 1.0 Received: by 10.216.93.17 with SMTP id k17mr981180wef.31.1265319588017; Thu, 04 Feb 2010 13:39:48 -0800 (PST) In-Reply-To: <201002040209.28922.vapier@gentoo.org> References: <201002040209.28922.vapier@gentoo.org> Date: Thu, 04 Feb 2010 21:39:00 -0000 Message-ID: Subject: Re: [patch] have sim-model.c include sim-model.h From: Doug Evans To: Mike Frysinger Cc: gdb-patches@sourceware.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-System-Of-Record: true X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-02/txt/msg00139.txt.bz2 On Wed, Feb 3, 2010 at 11:09 PM, Mike Frysinger wrote: > the sim-model.c code obviously uses things from sim-model.h, but doesnt > explicitly include it. =A0instead, it relies on sim-main.h to pull it in.= =A0when > doing a new port and building this file, the errors reported can be pretty > confusing. =A0so pull in sim-model.h to make the process a bit smoother. > > 2010-02-04 =A0Mike Frysinger =A0 > > =A0 =A0 =A0 =A0* sim-model.c: Include sim-model.h > > RCS file: /cvs/src/src/sim/common/sim-model.c,v > retrieving revision 1.6 > diff -u -p -r1.6 sim-model.c > --- sim/common/sim-model.c =A0 =A0 =A01 Jan 2010 10:03:27 -0000 =A0 =A0 = =A0 1.6 > +++ sim/common/sim-model.c =A0 =A0 =A04 Feb 2010 07:02:42 -0000 > @@ -19,6 +19,7 @@ You should have received a copy of the G > =A0along with this program. =A0If not, see = . =A0*/ > > =A0#include "sim-main.h" > +#include "sim-model.h" > =A0#include "libiberty.h" > =A0#include "sim-options.h" > =A0#include "sim-io.h" > Hi. This patch is ok with me. Thanks.