Can't build mips-elf-run on OSX

Can't build mips-elf-run on OSX

[Masaki Muranaka]

Hello maintainers,

I failed to build mips-elf-run on OSX (x86_64-apple-darwin10.2.0) host.
Error log is below.

The immediate cause is that stpcpy is defined as macro on OSX host.
But there seems have a general issue.

It is required config.h by bfd/sysdep.h. This should be bfd/config.h.
But gcc (at least apple's genuine build) includes sim/mips/config.h.
So definitions in bfd/config.h like HAVE_DECL_STPCPY is not defined.

To begin with, sim/mips/interp.c needs bfd/sysdep.h? 
I could built interp.c successfully without bfd/sysdep.h on my environment.

Thanks,

- - -
In file included from ../../../pf3gnuchains4x/sim/mips/interp.c:67:
../../../pf3gnuchains4x/sim/mips/../..//bfd/sysdep.h:135: error: expected declaration specifiers or ‘...’ before numeric constant
../../../pf3gnuchains4x/sim/mips/../..//bfd/sysdep.h:135: error: expected ‘)’ before ‘!=’ token
../../../pf3gnuchains4x/sim/mips/../..//bfd/sysdep.h:135: error: expected ‘)’ before ‘?’ token
make[2]: *** [interp.o] Error 1
make[1]: *** [all] Error 1
make: *** [all-sim] Error 2
- - -
--
Masaki Muranaka
Monami software

[patch] Re: Can't build mips-elf-run on OSX

[Masaki Muranaka]

Hello,
I remove binutils ML from the header since this issue is depended on sim only.

According to ChangeLog (Wed Jul 17 18:12:38 1996  Stu Grossman  (grossman@critters.cygnus.com)),
the reason why interp.c is to get SIGBUS definition.
I think we have already changed signal handling. So we don't need to include sysdep.h.

I tested the patch follows on i386-pc-mingw32, x86_64-unknown-linux-gnu, x86_64-apple-darwin10.2.0.

- - - - -
2010-01-07  Masaki Muranaka  <monaka@monami-software.com>

        * interp.c: Don't include sysdep.h

- - - - -
diff --git a/sim/mips/interp.c b/sim/mips/interp.c
index 20ab54b..5516e00 100644
--- a/sim/mips/interp.c
+++ b/sim/mips/interp.c
@@ -64,8 +64,6 @@ code on the hardware.
 #include "gdb/callback.h"   /* GDB simulator callback interface */
 #include "gdb/remote-sim.h" /* GDB simulator interface */
 
-#include "sysdep.h"
-
 #ifndef PARAMS
 #define PARAMS(x) 
 #endif

- - - - -
On 2010/01/06, at 20:28, Masaki Muranaka wrote:

> Hello maintainers,
> 
> I failed to build mips-elf-run on OSX (x86_64-apple-darwin10.2.0) host.
> Error log is below.
> 
> The immediate cause is that stpcpy is defined as macro on OSX host.
> But there seems have a general issue.
> 
> It is required config.h by bfd/sysdep.h. This should be bfd/config.h.
> But gcc (at least apple's genuine build) includes sim/mips/config.h.
> So definitions in bfd/config.h like HAVE_DECL_STPCPY is not defined.
> 
> To begin with, sim/mips/interp.c needs bfd/sysdep.h? 
> I could built interp.c successfully without bfd/sysdep.h on my environment.
> 
> Thanks,
> 
> - - -
> In file included from ../../../pf3gnuchains4x/sim/mips/interp.c:67:
> ../../../pf3gnuchains4x/sim/mips/../..//bfd/sysdep.h:135: error: expected declaration specifiers or ‘...’ before numeric constant
> ../../../pf3gnuchains4x/sim/mips/../..//bfd/sysdep.h:135: error: expected ‘)’ before ‘!=’ token
> ../../../pf3gnuchains4x/sim/mips/../..//bfd/sysdep.h:135: error: expected ‘)’ before ‘?’ token
> make[2]: *** [interp.o] Error 1
> make[1]: *** [all] Error 1
> make: *** [all-sim] Error 2
> - - -
> --
> Masaki Muranaka
> Monami software
> 
> 
> 

Re: Can't build mips-elf-run on OSX

[Nick Clifton]

Hi Masaki,

> It is required config.h by bfd/sysdep.h. This should be bfd/config.h.
> But gcc (at least apple's genuine build) includes sim/mips/config.h.
> So definitions in bfd/config.h like HAVE_DECL_STPCPY is not defined.

This sounds like a problem with the configure script in the sim/mips 
directory - presumably it should be including a check of the stpcpy 
function.

> To begin with, sim/mips/interp.c needs bfd/sysdep.h? 
> I could built interp.c successfully without bfd/sysdep.h on my environment.

Me too - so it would appear to be unnecessary.  Please note however that 
I cannot approved such a change - you need a GDB maintainer for that. 
Thiemo is listed as the sim/mips maintainer...

Cheers
   Nick

Re: Can't build mips-elf-run on OSX

[Masaki Muranaka]

Hello Nick,

Thanks for your comment. I figured out after sending that mail, so I already sent a patch to gdb-patches ML.
As you say, this issue is caused by sim/mips.

Thanks,

On 2010/01/08, at 1:37, Nick Clifton wrote:

> Hi Masaki,
> 
>> It is required config.h by bfd/sysdep.h. This should be bfd/config.h.
>> But gcc (at least apple's genuine build) includes sim/mips/config.h.
>> So definitions in bfd/config.h like HAVE_DECL_STPCPY is not defined.
> 
> This sounds like a problem with the configure script in the sim/mips directory - presumably it should be including a check of the stpcpy function.
> 
>> To begin with, sim/mips/interp.c needs bfd/sysdep.h? I could built interp.c successfully without bfd/sysdep.h on my environment.
> 
> Me too - so it would appear to be unnecessary.  Please note however that I cannot approved such a change - you need a GDB maintainer for that. Thiemo is listed as the sim/mips maintainer...
> 
> Cheers
>  Nick
> 
> 

[ping] Re: [patch] Re: Can't build mips-elf-run on OSX

[Masaki Muranaka]

ping?

On 2010/01/07, at 9:09, Masaki Muranaka wrote:

> Hello,
> I remove binutils ML from the header since this issue is depended on sim only.
> 
> According to ChangeLog (Wed Jul 17 18:12:38 1996  Stu Grossman  (grossman@critters.cygnus.com)),
> the reason why interp.c is to get SIGBUS definition.
> I think we have already changed signal handling. So we don't need to include sysdep.h.
> 
> I tested the patch follows on i386-pc-mingw32, x86_64-unknown-linux-gnu, x86_64-apple-darwin10.2.0.
> 
> - - - - -
> 2010-01-07  Masaki Muranaka  <monaka@monami-software.com>
> 
>        * interp.c: Don't include sysdep.h
> 
> - - - - -
> diff --git a/sim/mips/interp.c b/sim/mips/interp.c
> index 20ab54b..5516e00 100644
> --- a/sim/mips/interp.c
> +++ b/sim/mips/interp.c
> @@ -64,8 +64,6 @@ code on the hardware.
> #include "gdb/callback.h"   /* GDB simulator callback interface */
> #include "gdb/remote-sim.h" /* GDB simulator interface */
> 
> -#include "sysdep.h"
> -
> #ifndef PARAMS
> #define PARAMS(x) 
> #endif
> 
> - - - - -
> On 2010/01/06, at 20:28, Masaki Muranaka wrote:
> 
>> Hello maintainers,
>> 
>> I failed to build mips-elf-run on OSX (x86_64-apple-darwin10.2.0) host.
>> Error log is below.
>> 
>> The immediate cause is that stpcpy is defined as macro on OSX host.
>> But there seems have a general issue.
>> 
>> It is required config.h by bfd/sysdep.h. This should be bfd/config.h.
>> But gcc (at least apple's genuine build) includes sim/mips/config.h.
>> So definitions in bfd/config.h like HAVE_DECL_STPCPY is not defined.
>> 
>> To begin with, sim/mips/interp.c needs bfd/sysdep.h? 
>> I could built interp.c successfully without bfd/sysdep.h on my environment.
>> 
>> Thanks,
>> 
>> - - -
>> In file included from ../../../pf3gnuchains4x/sim/mips/interp.c:67:
>> ../../../pf3gnuchains4x/sim/mips/../..//bfd/sysdep.h:135: error: expected declaration specifiers or ‘...’ before numeric constant
>> ../../../pf3gnuchains4x/sim/mips/../..//bfd/sysdep.h:135: error: expected ‘)’ before ‘!=’ token
>> ../../../pf3gnuchains4x/sim/mips/../..//bfd/sysdep.h:135: error: expected ‘)’ before ‘?’ token
>> make[2]: *** [interp.o] Error 1
>> make[1]: *** [all] Error 1
>> make: *** [all-sim] Error 2
>> - - -
>> --
>> Masaki Muranaka
>> Monami software
>> 
>> 
>> 
> 
> 

Re: [patch] Re: Can't build mips-elf-run on OSX

[Joel Brobecker]

> 2010-01-07  Masaki Muranaka  <monaka@monami-software.com>
> 
>         * interp.c: Don't include sysdep.h

Sorry for the delay, but I wanted to see if one of the sim maintainers
would step in and review.

This is approved.

I cannot locate you in our FSF copyright assignment database.
Do you have a copyright assignment on file?  In the meantime,
we can accept this patch under the small change rule.

-- 
Joel

Re: [patch] Re: Can't build mips-elf-run on OSX

[Masaki Muranaka]

Hello,

I requested assignment but I've not get it (maybe troubles in transit).
I sent request again just before. I'll sign the assignment for a couple of weeks.
(But my patches are all tiny. So I think they can be applied the small
 change rule as you say.)

On 2010/01/18, at 12:27, Joel Brobecker wrote:

>> 2010-01-07  Masaki Muranaka  <monaka@monami-software.com>
>> 
>>        * interp.c: Don't include sysdep.h
> 
> Sorry for the delay, but I wanted to see if one of the sim maintainers
> would step in and review.
> 
> This is approved.
> 
> I cannot locate you in our FSF copyright assignment database.
> Do you have a copyright assignment on file?  In the meantime,
> we can accept this patch under the small change rule.
> 
> -- 
> Joel
> 

Re: [patch] Re: Can't build mips-elf-run on OSX

[Joel Brobecker]

> I requested assignment but I've not get it (maybe troubles in transit).

OK - hopefully just in transit, but do check with the FSF clerk,
say, in a couple of weeks, if you haven't heard from the FSF.

> (But my patches are all tiny. So I think they can be applied the small
>  change rule as you say.)

I wasn't clear in my earlier message, sorry. I have already applied
your patch.

-- 
Joel