[ping] Re: [patch] Re: Can't build mips-elf-run on OSX

[Masaki Muranaka <monaka@monami-software.com>]

ping?

On 2010/01/07, at 9:09, Masaki Muranaka wrote:

> Hello,
> I remove binutils ML from the header since this issue is depended on sim only.
> 
> According to ChangeLog (Wed Jul 17 18:12:38 1996  Stu Grossman  (grossman@critters.cygnus.com)),
> the reason why interp.c is to get SIGBUS definition.
> I think we have already changed signal handling. So we don't need to include sysdep.h.
> 
> I tested the patch follows on i386-pc-mingw32, x86_64-unknown-linux-gnu, x86_64-apple-darwin10.2.0.
> 
> - - - - -
> 2010-01-07  Masaki Muranaka  <monaka@monami-software.com>
> 
>        * interp.c: Don't include sysdep.h
> 
> - - - - -
> diff --git a/sim/mips/interp.c b/sim/mips/interp.c
> index 20ab54b..5516e00 100644
> --- a/sim/mips/interp.c
> +++ b/sim/mips/interp.c
> @@ -64,8 +64,6 @@ code on the hardware.
> #include "gdb/callback.h"   /* GDB simulator callback interface */
> #include "gdb/remote-sim.h" /* GDB simulator interface */
> 
> -#include "sysdep.h"
> -
> #ifndef PARAMS
> #define PARAMS(x) 
> #endif
> 
> - - - - -
> On 2010/01/06, at 20:28, Masaki Muranaka wrote:
> 
>> Hello maintainers,
>> 
>> I failed to build mips-elf-run on OSX (x86_64-apple-darwin10.2.0) host.
>> Error log is below.
>> 
>> The immediate cause is that stpcpy is defined as macro on OSX host.
>> But there seems have a general issue.
>> 
>> It is required config.h by bfd/sysdep.h. This should be bfd/config.h.
>> But gcc (at least apple's genuine build) includes sim/mips/config.h.
>> So definitions in bfd/config.h like HAVE_DECL_STPCPY is not defined.
>> 
>> To begin with, sim/mips/interp.c needs bfd/sysdep.h? 
>> I could built interp.c successfully without bfd/sysdep.h on my environment.
>> 
>> Thanks,
>> 
>> - - -
>> In file included from ../../../pf3gnuchains4x/sim/mips/interp.c:67:
>> ../../../pf3gnuchains4x/sim/mips/../..//bfd/sysdep.h:135: error: expected declaration specifiers or ‘...’ before numeric constant
>> ../../../pf3gnuchains4x/sim/mips/../..//bfd/sysdep.h:135: error: expected ‘)’ before ‘!=’ token
>> ../../../pf3gnuchains4x/sim/mips/../..//bfd/sysdep.h:135: error: expected ‘)’ before ‘?’ token
>> make[2]: *** [interp.o] Error 1
>> make[1]: *** [all] Error 1
>> make: *** [all-sim] Error 2
>> - - -
>> --
>> Masaki Muranaka
>> Monami software
>> 
>> 
>> 
> 
>