From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4610 invoked by alias); 7 Jan 2010 00:09:56 -0000 Received: (qmail 4594 invoked by uid 22791); 7 Jan 2010 00:09:54 -0000 X-SWARE-Spam-Status: No, hits=-2.4 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from p12018-ipbffx02marunouchi.tokyo.ocn.ne.jp (HELO mail.pizzafactory.jp) (222.147.75.18) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 07 Jan 2010 00:09:50 +0000 Received: from localhost (localhost [127.0.0.1]) by mail.pizzafactory.jp (Postfix) with ESMTP id BFF1A590893E for ; Thu, 7 Jan 2010 09:09:56 +0900 (JST) Received: from mail.pizzafactory.jp ([127.0.0.1]) by localhost (ldap.monami-software.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id GjfITHDxyZCK for ; Thu, 7 Jan 2010 09:09:56 +0900 (JST) Received: from [192.168.0.9] (unknown [192.168.0.9]) by mail.pizzafactory.jp (Postfix) with ESMTP id 637B75908937 for ; Thu, 7 Jan 2010 09:09:56 +0900 (JST) Content-Type: text/plain; charset=iso-2022-jp Mime-Version: 1.0 (Apple Message framework v1077) Subject: [patch] Re: Can't build mips-elf-run on OSX From: Masaki Muranaka In-Reply-To: Date: Thu, 07 Jan 2010 00:09:00 -0000 Content-Transfer-Encoding: quoted-printable Message-Id: <72B223AD-7BA5-45E5-96F4-3D0819097484@monami-software.com> References: To: gdb-patches@sourceware.org X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-01/txt/msg00128.txt.bz2 Hello, I remove binutils ML from the header since this issue is depended on sim on= ly. According to ChangeLog (Wed Jul 17 18:12:38 1996 Stu Grossman (grossman@c= ritters.cygnus.com)), the reason why interp.c is to get SIGBUS definition. I think we have already changed signal handling. So we don't need to includ= e sysdep.h. I tested the patch follows on i386-pc-mingw32, x86_64-unknown-linux-gnu, x8= 6_64-apple-darwin10.2.0. - - - - - 2010-01-07 Masaki Muranaka * interp.c: Don't include sysdep.h - - - - - diff --git a/sim/mips/interp.c b/sim/mips/interp.c index 20ab54b..5516e00 100644 --- a/sim/mips/interp.c +++ b/sim/mips/interp.c @@ -64,8 +64,6 @@ code on the hardware. #include "gdb/callback.h" /* GDB simulator callback interface */ #include "gdb/remote-sim.h" /* GDB simulator interface */ =20 -#include "sysdep.h" - #ifndef PARAMS #define PARAMS(x)=20 #endif - - - - - On 2010/01/06, at 20:28, Masaki Muranaka wrote: > Hello maintainers, >=20 > I failed to build mips-elf-run on OSX (x86_64-apple-darwin10.2.0) host. > Error log is below. >=20 > The immediate cause is that stpcpy is defined as macro on OSX host. > But there seems have a general issue. >=20 > It is required config.h by bfd/sysdep.h. This should be bfd/config.h. > But gcc (at least apple's genuine build) includes sim/mips/config.h. > So definitions in bfd/config.h like HAVE_DECL_STPCPY is not defined. >=20 > To begin with, sim/mips/interp.c needs bfd/sysdep.h?=20 > I could built interp.c successfully without bfd/sysdep.h on my environmen= t. >=20 > Thanks, >=20 > - - - > In file included from ../../../pf3gnuchains4x/sim/mips/interp.c:67: > ../../../pf3gnuchains4x/sim/mips/../..//bfd/sysdep.h:135: error: expected= declaration specifiers or =1B$B!F=1B(B...=1B$B!G=1B(B before numeric const= ant > ../../../pf3gnuchains4x/sim/mips/../..//bfd/sysdep.h:135: error: expected= =1B$B!F=1B(B)=1B$B!G=1B(B before =1B$B!F=1B(B!=3D=1B$B!G=1B(B token > ../../../pf3gnuchains4x/sim/mips/../..//bfd/sysdep.h:135: error: expected= =1B$B!F=1B(B)=1B$B!G=1B(B before =1B$B!F=1B(B?=1B$B!G=1B(B token > make[2]: *** [interp.o] Error 1 > make[1]: *** [all] Error 1 > make: *** [all-sim] Error 2 > - - - > -- > Masaki Muranaka > Monami software >=20 >=20 >=20