Re: [rfc] longjmp breakpoints (Re: [00/19] Eliminate some more current_gdbarch uses)

["Ulrich Weigand" <uweigand@de.ibm.com>]

Pedro Alves wrote:

> > This patch implements the idea of maintaining "master copies" of the
> > longjmp breakpoints that are created at the same places where overlay
> > event breakpoints are created today, and then installing momentary
> > clones while we want them to be active within a thread.
> > 
> > What do you think?
> 
> Looks good to me.  Thanks!

Thanks for the review!

I've noticed the patch as posted as a silly bug:

> > +  ALL_BREAKPOINTS_SAFE (b, temp)
> > +    if (b->type == bp_longjmp_master)
> > +      {
> > +	struct breakpoint *clone = clone_momentary_breakpoint (b);
> > +	b->type = bp_longjmp;
> > +	b->thread = thread;
> > +      }

This obviously needs to set clone->type and clone->thread instead.

I've now re-tested and checked in the fixed version.

Bye,
Ulrich

-- 
  Dr. Ulrich Weigand
  GNU Toolchain for Linux on System z and Cell BE
  Ulrich.Weigand@de.ibm.com