From: Pedro Alves <pedro@codesourcery.com>
To: gdb-patches@sourceware.org
Cc: "Ulrich Weigand" <uweigand@de.ibm.com>
Subject: Re: [00/19] Eliminate some more current_gdbarch uses
Date: Fri, 05 Jun 2009 22:24:00 -0000 [thread overview]
Message-ID: <200906052325.03584.pedro@codesourcery.com> (raw)
In-Reply-To: <200906052113.n55LDMj4025990@d12av02.megacenter.de.ibm.com>
I took a first-pass-cursory look throughout the series, and I
don't have much to add. It all looked good to me. The
only things that jumped out were:
- We should do something smarter about longjmp breakpoint
lookup at some point.
- I have a gut feeling that a single gdbarch per expression is
going to byte us back somewhere along the line, but that's not
a problem of this patch.
--
Pedro Alves
next prev parent reply other threads:[~2009-06-05 22:24 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-05 21:13 Ulrich Weigand
2009-06-05 22:24 ` Pedro Alves [this message]
2009-06-05 22:54 ` Tom Tromey
2009-06-05 23:30 ` Pedro Alves
2009-06-08 14:38 ` Ulrich Weigand
2009-06-08 14:48 ` Pedro Alves
2009-06-23 18:04 ` [rfc] longjmp breakpoints (Re: [00/19] Eliminate some more current_gdbarch uses) Ulrich Weigand
2009-06-24 15:02 ` Pedro Alves
2009-06-24 16:44 ` Ulrich Weigand
2009-06-17 18:58 ` [00/19] Eliminate some more current_gdbarch uses Ulrich Weigand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200906052325.03584.pedro@codesourcery.com \
--to=pedro@codesourcery.com \
--cc=gdb-patches@sourceware.org \
--cc=uweigand@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox