From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 396 invoked by alias); 5 Jun 2009 22:24:20 -0000 Received: (qmail 388 invoked by uid 22791); 5 Jun 2009 22:24:19 -0000 X-SWARE-Spam-Status: No, hits=-2.4 required=5.0 tests=AWL,BAYES_00,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (65.74.133.4) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 05 Jun 2009 22:24:14 +0000 Received: (qmail 25959 invoked from network); 5 Jun 2009 22:24:12 -0000 Received: from unknown (HELO orlando.local) (pedro@127.0.0.2) by mail.codesourcery.com with ESMTPA; 5 Jun 2009 22:24:12 -0000 From: Pedro Alves To: gdb-patches@sourceware.org Subject: Re: [00/19] Eliminate some more current_gdbarch uses Date: Fri, 05 Jun 2009 22:24:00 -0000 User-Agent: KMail/1.9.10 Cc: "Ulrich Weigand" References: <200906052113.n55LDMj4025990@d12av02.megacenter.de.ibm.com> In-Reply-To: <200906052113.n55LDMj4025990@d12av02.megacenter.de.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200906052325.03584.pedro@codesourcery.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-06/txt/msg00141.txt.bz2 I took a first-pass-cursory look throughout the series, and I don't have much to add. It all looked good to me. The only things that jumped out were: - We should do something smarter about longjmp breakpoint lookup at some point. - I have a gut feeling that a single gdbarch per expression is going to byte us back somewhere along the line, but that's not a problem of this patch. -- Pedro Alves