Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Pedro Alves <pedro@codesourcery.com>
To: gdb-patches@sourceware.org
Cc: "Ulrich Weigand" <uweigand@de.ibm.com>,  tromey@redhat.com
Subject: Re: [00/19] Eliminate some more current_gdbarch uses
Date: Mon, 08 Jun 2009 14:48:00 -0000	[thread overview]
Message-ID: <200906081549.28627.pedro@codesourcery.com> (raw)
In-Reply-To: <200906081438.n58EcdKE022828@d12av02.megacenter.de.ibm.com>

On Monday 08 June 2009 15:38:39, Ulrich Weigand wrote:
> Of course, this would mean the breakpoints were always active.  However,
> this could be improved upon by:

> - having infrun ignore longjmp breakpoints if not stepping

If there isn't any thread doing a command that requires longjmp
breakpoints, I'd really like to not have them inserted, it's inneficient
for "continue".  Plus, threads hit longjmps on their way to
exiting (on linux/pthreads) --- and it's best to avoid it, with all
the nasty longjmp issues (pointer mangling) we have.

> - keeping them disabled unless stepping (and still have infrun ignore
>   longjmp breakpoints when hit in the wrong thread)

Yeah, I can see that working.

> and/or
> - keeping them always disabled, but installing momentary clones in
>   threads that are stepping

Yeah, sounds sort of good too.  I've added a momentary breakpoint
cloning function just a few days ago.  This requires looking up which
threads in the same address space are stepping.  I'm not certain which
version would be uglier.  Currently, it's the address lookup part
that's ineficient.  We could tackle that with per-objfile data, without
making the breakpoints module much aware of stepping.

-- 
Pedro Alves


  reply	other threads:[~2009-06-08 14:48 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-06-05 21:13 Ulrich Weigand
2009-06-05 22:24 ` Pedro Alves
2009-06-05 22:54   ` Tom Tromey
2009-06-05 23:30     ` Pedro Alves
2009-06-08 14:38       ` Ulrich Weigand
2009-06-08 14:48         ` Pedro Alves [this message]
2009-06-23 18:04           ` [rfc] longjmp breakpoints (Re: [00/19] Eliminate some more current_gdbarch uses) Ulrich Weigand
2009-06-24 15:02             ` Pedro Alves
2009-06-24 16:44               ` Ulrich Weigand
2009-06-17 18:58 ` [00/19] Eliminate some more current_gdbarch uses Ulrich Weigand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200906081549.28627.pedro@codesourcery.com \
    --to=pedro@codesourcery.com \
    --cc=gdb-patches@sourceware.org \
    --cc=tromey@redhat.com \
    --cc=uweigand@de.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox