From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13519 invoked by alias); 24 Jun 2009 16:44:17 -0000 Received: (qmail 13507 invoked by uid 22791); 24 Jun 2009 16:44:16 -0000 X-SWARE-Spam-Status: No, hits=-1.4 required=5.0 tests=AWL,BAYES_00,MSGID_FROM_MTA_HEADER,SPF_SOFTFAIL X-Spam-Check-By: sourceware.org Received: from mtagate4.de.ibm.com (HELO mtagate4.de.ibm.com) (195.212.29.153) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 24 Jun 2009 16:44:02 +0000 Received: from d12nrmr1607.megacenter.de.ibm.com (d12nrmr1607.megacenter.de.ibm.com [9.149.167.49]) by mtagate4.de.ibm.com (8.14.3/8.13.8) with ESMTP id n5OGhwUa025160 for ; Wed, 24 Jun 2009 16:43:58 GMT Received: from d12av02.megacenter.de.ibm.com (d12av02.megacenter.de.ibm.com [9.149.165.228]) by d12nrmr1607.megacenter.de.ibm.com (8.13.8/8.13.8/NCO v9.2) with ESMTP id n5OGhvZe3490010 for ; Wed, 24 Jun 2009 18:43:57 +0200 Received: from d12av02.megacenter.de.ibm.com (loopback [127.0.0.1]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id n5OGhvqh027426 for ; Wed, 24 Jun 2009 18:43:57 +0200 Received: from tuxmaker.boeblingen.de.ibm.com (tuxmaker.boeblingen.de.ibm.com [9.152.85.9]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.12.11) with SMTP id n5OGhuxw027407; Wed, 24 Jun 2009 18:43:56 +0200 Message-Id: <200906241643.n5OGhuxw027407@d12av02.megacenter.de.ibm.com> Received: by tuxmaker.boeblingen.de.ibm.com (sSMTP sendmail emulation); Wed, 24 Jun 2009 18:43:56 +0200 Subject: Re: [rfc] longjmp breakpoints (Re: [00/19] Eliminate some more current_gdbarch uses) To: pedro@codesourcery.com (Pedro Alves) Date: Wed, 24 Jun 2009 16:44:00 -0000 From: "Ulrich Weigand" Cc: gdb-patches@sourceware.org, tromey@redhat.com In-Reply-To: <200906241603.34227.pedro@codesourcery.com> from "Pedro Alves" at Jun 24, 2009 04:03:33 PM MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-06/txt/msg00647.txt.bz2 Pedro Alves wrote: > > This patch implements the idea of maintaining "master copies" of the > > longjmp breakpoints that are created at the same places where overlay > > event breakpoints are created today, and then installing momentary > > clones while we want them to be active within a thread. > > > > What do you think? > > Looks good to me. Thanks! Thanks for the review! I've noticed the patch as posted as a silly bug: > > + ALL_BREAKPOINTS_SAFE (b, temp) > > + if (b->type == bp_longjmp_master) > > + { > > + struct breakpoint *clone = clone_momentary_breakpoint (b); > > + b->type = bp_longjmp; > > + b->thread = thread; > > + } This obviously needs to set clone->type and clone->thread instead. I've now re-tested and checked in the fixed version. Bye, Ulrich -- Dr. Ulrich Weigand GNU Toolchain for Linux on System z and Cell BE Ulrich.Weigand@de.ibm.com