Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Pedro Alves <pedro@codesourcery.com>
To: gdb-patches@sourceware.org
Cc: Joel Brobecker <brobecker@adacore.com>,
	 Pierre Muller <muller@ics.u-strasbg.fr>
Subject: Re: [RFA/Windows] Remove ADD_SHARED_SYMBOL_FILES macro
Date: Mon, 25 May 2009 23:13:00 -0000	[thread overview]
Message-ID: <200905260014.02926.pedro@codesourcery.com> (raw)
In-Reply-To: <20090525225725.GI23016@adacore.com>

On Monday 25 May 2009 23:57:25, Joel Brobecker wrote:
> >        (_initialize _symfile): Move "add-shared-symbol-files"
> >        command and "assf" alias.
> >        * windows-nat.c (_initialize_windows_nat): to here.
> >        Change "add-shared-symbol-files" to alias.
> 
> I propose we deprecate these aliases as well; does it really make sense
> to have 2 identical commands?
> 

Well, let me go the other way around.  Why is "dll-symbols" needed
at all?  Why isn't "add-symbol-file" good enough?  Other than the
ugly safe_symbol_file_add hack that would be nice to get rid of,
and setting OBJF_SHARED (itself dubious) it doesn't have anything Windows
specific at all (magically appending ".dll" doesn't count).

-- 
Pedro Alves


  reply	other threads:[~2009-05-25 23:13 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-05-14 22:23 [RFA] " Pierre Muller
2009-05-22 15:30 ` [RFA/Windows] " Joel Brobecker
2009-05-22 17:10   ` Christopher Faylor
2009-05-24 12:36     ` Pierre Muller
2009-05-25  6:17       ` Joel Brobecker
2009-05-25  8:40         ` Pierre Muller
2009-05-25 22:57           ` Joel Brobecker
2009-05-25 23:13             ` Pedro Alves [this message]
2009-06-22 20:50               ` Joel Brobecker
2009-06-23  1:55                 ` Christopher Faylor
2009-06-24 17:03                   ` Pedro Alves

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200905260014.02926.pedro@codesourcery.com \
    --to=pedro@codesourcery.com \
    --cc=brobecker@adacore.com \
    --cc=gdb-patches@sourceware.org \
    --cc=muller@ics.u-strasbg.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox