From: Joel Brobecker <brobecker@adacore.com>
To: Pierre Muller <muller@ics.u-strasbg.fr>
Cc: gdb-patches@sourceware.org
Subject: Re: [RFA/Windows] Remove ADD_SHARED_SYMBOL_FILES macro
Date: Fri, 22 May 2009 15:30:00 -0000 [thread overview]
Message-ID: <20090522153042.GB23016@adacore.com> (raw)
In-Reply-To: <003d01c9d4e2$987399a0$c95acce0$@u-strasbg.fr>
> 2009-05-15 Pierre Muller <muller@ics.u-strasbg.fr>
>
> * symfile.c (add_shared_symbol_files_command): Remove
> prototype and function.
> (_initialize _symfile): Move "add-shared-symbol-files"
> command and "assf" alias.
This part is fine.
> * windows-nat.c (_initialize_windows_nat): to here.
This part, however, is unnecessary, I think. There is already a command
called dll-symbols that calls the very same function (dll_symbol_command).
My suggestion would be to delete the add-shared-symbols-files entirely,
or to make it a deprecated alias to dll-symbols.
Chris, what do you think?
> * config/i386/cygwin.mh: Remove NAT_FILE.
> * config/i386/mingw.mh: Remove NAT_FILE.
> * config/i386/mingw64.mh: Remove NAT_FILE.
> * config/i386/nm-cygwin.h: Remove file.
> * config/i386/nm-cygwin64.h: Remove file.
This part is fine.
Thanks for doing this,
--
Joel
next prev parent reply other threads:[~2009-05-22 15:30 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-14 22:23 [RFA] " Pierre Muller
2009-05-22 15:30 ` Joel Brobecker [this message]
2009-05-22 17:10 ` [RFA/Windows] " Christopher Faylor
2009-05-24 12:36 ` Pierre Muller
2009-05-25 6:17 ` Joel Brobecker
2009-05-25 8:40 ` Pierre Muller
2009-05-25 22:57 ` Joel Brobecker
2009-05-25 23:13 ` Pedro Alves
2009-06-22 20:50 ` Joel Brobecker
2009-06-23 1:55 ` Christopher Faylor
2009-06-24 17:03 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090522153042.GB23016@adacore.com \
--to=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=muller@ics.u-strasbg.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox