From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23943 invoked by alias); 22 May 2009 15:30:55 -0000 Received: (qmail 23920 invoked by uid 22791); 22 May 2009 15:30:52 -0000 X-SWARE-Spam-Status: No, hits=-1.7 required=5.0 tests=AWL,BAYES_00,KAM_STOCKGEN X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 22 May 2009 15:30:47 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id AB60C2BACEF; Fri, 22 May 2009 11:30:44 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id KyOWnZ2mZb+d; Fri, 22 May 2009 11:30:44 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 3B29B2BACD6; Fri, 22 May 2009 11:30:44 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id 0C83DF5965; Fri, 22 May 2009 17:30:42 +0200 (CEST) Date: Fri, 22 May 2009 15:30:00 -0000 From: Joel Brobecker To: Pierre Muller Cc: gdb-patches@sourceware.org Subject: Re: [RFA/Windows] Remove ADD_SHARED_SYMBOL_FILES macro Message-ID: <20090522153042.GB23016@adacore.com> References: <003d01c9d4e2$987399a0$c95acce0$@u-strasbg.fr> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <003d01c9d4e2$987399a0$c95acce0$@u-strasbg.fr> User-Agent: Mutt/1.5.18 (2008-05-17) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-05/txt/msg00494.txt.bz2 > 2009-05-15 Pierre Muller > > * symfile.c (add_shared_symbol_files_command): Remove > prototype and function. > (_initialize _symfile): Move "add-shared-symbol-files" > command and "assf" alias. This part is fine. > * windows-nat.c (_initialize_windows_nat): to here. This part, however, is unnecessary, I think. There is already a command called dll-symbols that calls the very same function (dll_symbol_command). My suggestion would be to delete the add-shared-symbols-files entirely, or to make it a deprecated alias to dll-symbols. Chris, what do you think? > * config/i386/cygwin.mh: Remove NAT_FILE. > * config/i386/mingw.mh: Remove NAT_FILE. > * config/i386/mingw64.mh: Remove NAT_FILE. > * config/i386/nm-cygwin.h: Remove file. > * config/i386/nm-cygwin64.h: Remove file. This part is fine. Thanks for doing this, -- Joel