RE: [RFA/Windows] Remove ADD_SHARED_SYMBOL_FILES macro

["Pierre Muller" <muller@ics.u-strasbg.fr>]

> -----Message d'origine-----
> De : gdb-patches-owner@sourceware.org [mailto:gdb-patches-
> owner@sourceware.org] De la part de Christopher Faylor
> Envoyé : Friday, May 22, 2009 7:10 PM
> À : gdb-patches@sourceware.org; Joel Brobecker; Pierre Muller
> Objet : Re: [RFA/Windows] Remove ADD_SHARED_SYMBOL_FILES macro
> 
> Thanks for relabelling the subject so that I'd notice it.
> 
> On Fri, May 22, 2009 at 08:30:42AM -0700, Joel Brobecker wrote:
> >> 2009-05-15  Pierre Muller  <muller@ics.u-strasbg.fr>
> >>
> >> 	* symfile.c (add_shared_symbol_files_command): Remove
> >> 	prototype and function.
> >> 	(_initialize _symfile): Move "add-shared-symbol-files"
> >> 	command and "assf" alias.
> >
> >This part is fine.
> >
> >> 	* windows-nat.c (_initialize_windows_nat): to here.
> >
> >This part, however, is unnecessary, I think.  There is already a
> command
> >called dll-symbols that calls the very same function
> (dll_symbol_command).
> >My suggestion would be to delete the add-shared-symbols-files
> entirely,
> >or to make it a deprecated alias to dll-symbols.
> >
> >Chris, what do you think?
> 
> I don't know enough about how other people use this command.  I use
> dll-symbols all of the time (for one specific dll which shall go
> unamed).  I don't know if people are using other commands instead so I
> don't think it can be deleted.  Making it an alias makes sense, though.
> 
> With that change, I'm fine with checking this in.
Thanks, I committed the patch with
add-shared-symbol-files as an alias.

This patch removes config/i386/nm-cygwin*.h headers
If I try to do a
simple make at gdb level I get this:
$ make
# Regenerate the Makefile and the tm.h / nm.h links.
CONFIG_FILES="Makefile" \
          CONFIG_COMMANDS= \
          CONFIG_HEADERS= \
          /bin/sh config.status
config.status: creating Makefile
config.status: linking ../../purecvs/gdb/config/i386/nm-cygwin.h to nm.h
config.status: error: ../../purecvs/gdb/config/i386/nm-cygwin.h: file not
found
make: *** [Makefile] Error 1

Is this an error in the Makefile?

Going up one level and doing 'make all-gdb' doesn't help,
but doing a
./config.status --recheck 
allows to get complilation to succeed again.
(I didn't try 'make clean all', this might be enough...)
 
Pierre Muller
Pascal language support maintainer for GDB