From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7765 invoked by alias); 24 May 2009 12:36:14 -0000 Received: (qmail 7754 invoked by uid 22791); 24 May 2009 12:36:12 -0000 X-SWARE-Spam-Status: No, hits=-1.2 required=5.0 tests=AWL,BAYES_00,J_CHICKENPOX_66,KAM_STOCKGEN X-Spam-Check-By: sourceware.org Received: from mailhost.u-strasbg.fr (HELO mailhost.u-strasbg.fr) (130.79.200.153) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sun, 24 May 2009 12:36:07 +0000 Received: from baal.u-strasbg.fr (baal.u-strasbg.fr [IPv6:2001:660:2402::41]) by mailhost.u-strasbg.fr (8.14.2/jtpda-5.5pre1) with ESMTP id n4OCZf69096441 ; Sun, 24 May 2009 14:35:41 +0200 (CEST) Received: from mailserver.u-strasbg.fr (ms1.u-strasbg.fr [IPv6:2001:660:2402:d::10]) by baal.u-strasbg.fr (8.14.0/jtpda-5.5pre1) with ESMTP id n4OCZfvW024572 ; Sun, 24 May 2009 14:35:41 +0200 (CEST) (envelope-from muller@ics.u-strasbg.fr) Received: from d620muller (lec67-4-82-230-53-140.fbx.proxad.net [82.230.53.140]) (user=mullerp mech=LOGIN) by mailserver.u-strasbg.fr (8.14.3/jtpda-5.5pre1) with ESMTP id n4OCZeAa032033 (version=TLSv1/SSLv3 cipher=RC4-MD5 bits=128 verify=NO) ; Sun, 24 May 2009 14:35:41 +0200 (CEST) (envelope-from muller@ics.u-strasbg.fr) From: "Pierre Muller" To: , "'Joel Brobecker'" References: <003d01c9d4e2$987399a0$c95acce0$@u-strasbg.fr> <20090522153042.GB23016@adacore.com> <20090522171005.GC15288@ednor.casa.cgf.cx> In-Reply-To: <20090522171005.GC15288@ednor.casa.cgf.cx> Subject: RE: [RFA/Windows] Remove ADD_SHARED_SYMBOL_FILES macro Date: Sun, 24 May 2009 12:36:00 -0000 Message-ID: <004301c9dc6c$29d6a000$7d83e000$@u-strasbg.fr> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-05/txt/msg00530.txt.bz2 > -----Message d'origine----- > De=A0: gdb-patches-owner@sourceware.org [mailto:gdb-patches- > owner@sourceware.org] De la part de Christopher Faylor > Envoy=E9=A0: Friday, May 22, 2009 7:10 PM > =C0=A0: gdb-patches@sourceware.org; Joel Brobecker; Pierre Muller > Objet=A0: Re: [RFA/Windows] Remove ADD_SHARED_SYMBOL_FILES macro >=20 > Thanks for relabelling the subject so that I'd notice it. >=20 > On Fri, May 22, 2009 at 08:30:42AM -0700, Joel Brobecker wrote: > >> 2009-05-15 Pierre Muller > >> > >> * symfile.c (add_shared_symbol_files_command): Remove > >> prototype and function. > >> (_initialize _symfile): Move "add-shared-symbol-files" > >> command and "assf" alias. > > > >This part is fine. > > > >> * windows-nat.c (_initialize_windows_nat): to here. > > > >This part, however, is unnecessary, I think. There is already a > command > >called dll-symbols that calls the very same function > (dll_symbol_command). > >My suggestion would be to delete the add-shared-symbols-files > entirely, > >or to make it a deprecated alias to dll-symbols. > > > >Chris, what do you think? >=20 > I don't know enough about how other people use this command. I use > dll-symbols all of the time (for one specific dll which shall go > unamed). I don't know if people are using other commands instead so I > don't think it can be deleted. Making it an alias makes sense, though. >=20 > With that change, I'm fine with checking this in. Thanks, I committed the patch with add-shared-symbol-files as an alias. This patch removes config/i386/nm-cygwin*.h headers If I try to do a simple make at gdb level I get this: $ make # Regenerate the Makefile and the tm.h / nm.h links. CONFIG_FILES=3D"Makefile" \ CONFIG_COMMANDS=3D \ CONFIG_HEADERS=3D \ /bin/sh config.status config.status: creating Makefile config.status: linking ../../purecvs/gdb/config/i386/nm-cygwin.h to nm.h config.status: error: ../../purecvs/gdb/config/i386/nm-cygwin.h: file not found make: *** [Makefile] Error 1 Is this an error in the Makefile? Going up one level and doing 'make all-gdb' doesn't help, but doing a ./config.status --recheck=20 allows to get complilation to succeed again. (I didn't try 'make clean all', this might be enough...) =20 Pierre Muller Pascal language support maintainer for GDB