From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-64008-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 32186 invoked by alias); 25 May 2009 23:13:58 -0000
Received: (qmail 32176 invoked by uid 22791); 25 May 2009 23:13:55 -0000
X-SWARE-Spam-Status: No, hits=-1.6 required=5.0 	tests=AWL,BAYES_00,KAM_STOCKGEN,SPF_PASS
X-Spam-Check-By: sourceware.org
Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (65.74.133.4)     by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 25 May 2009 23:13:45 +0000
Received: (qmail 559 invoked from network); 25 May 2009 23:13:43 -0000
Received: from unknown (HELO orlando.local) (pedro@127.0.0.2)   by mail.codesourcery.com with ESMTPA; 25 May 2009 23:13:43 -0000
From: Pedro Alves <pedro@codesourcery.com>
To: gdb-patches@sourceware.org
Subject: Re: [RFA/Windows] Remove ADD_SHARED_SYMBOL_FILES macro
Date: Mon, 25 May 2009 23:13:00 -0000
User-Agent: KMail/1.9.10
Cc: Joel Brobecker <brobecker@adacore.com>,  Pierre Muller <muller@ics.u-strasbg.fr>
References: <003d01c9d4e2$987399a0$c95acce0$@u-strasbg.fr> <006e01c9dd14$5a9cf510$0fd6df30$@u-strasbg.fr> <20090525225725.GI23016@adacore.com>
In-Reply-To: <20090525225725.GI23016@adacore.com>
MIME-Version: 1.0
Content-Type: text/plain;   charset="us-ascii"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200905260014.02926.pedro@codesourcery.com>
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2009-05/txt/msg00571.txt.bz2

On Monday 25 May 2009 23:57:25, Joel Brobecker wrote:
> >        (_initialize _symfile): Move "add-shared-symbol-files"
> >        command and "assf" alias.
> >        * windows-nat.c (_initialize_windows_nat): to here.
> >        Change "add-shared-symbol-files" to alias.
> 
> I propose we deprecate these aliases as well; does it really make sense
> to have 2 identical commands?
> 

Well, let me go the other way around.  Why is "dll-symbols" needed
at all?  Why isn't "add-symbol-file" good enough?  Other than the
ugly safe_symbol_file_add hack that would be nice to get rid of,
and setting OBJF_SHARED (itself dubious) it doesn't have anything Windows
specific at all (magically appending ".dll" doesn't count).

-- 
Pedro Alves