From: Joel Brobecker <brobecker@adacore.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: drow@false.org, gdb-patches@sourceware.org
Subject: Re: [RFA] Fix "break foo" when `foo's prologue ends before line table
Date: Mon, 25 May 2009 07:26:00 -0000 [thread overview]
Message-ID: <20090525072550.GF23016@adacore.com> (raw)
In-Reply-To: <83k548t94h.fsf@gnu.org>
> > > + /* Linetable entries are ordered by PC values, see the commentary in
> > ^^^^^^ comment
>
> Hmm? are you saying that "commentary" is incorrect English? If so, I
> beg to differ. ;-)
It seems to me that "commentary" would be used in a different context,
not to refer to some text describing what a piece of code does. But
I'm not a native English speaker, so I might be wrong.
> Is the comment I added before the call to skip_prologue_using_lineinfo
> good enough?
It looks great to me :)
--
Joel
next prev parent reply other threads:[~2009-05-25 7:26 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-09 14:26 Eli Zaretskii
2009-05-11 12:56 ` Joel Brobecker
2009-05-11 18:21 ` Eli Zaretskii
2009-05-11 19:27 ` Joel Brobecker
2009-05-11 20:49 ` Eli Zaretskii
2009-05-11 21:20 ` Daniel Jacobowitz
2009-05-12 3:13 ` Eli Zaretskii
2009-05-11 21:28 ` Joel Brobecker
2009-05-16 11:18 ` Eli Zaretskii
2009-05-20 23:07 ` Joel Brobecker
2009-05-23 10:20 ` Eli Zaretskii
2009-05-25 7:26 ` Joel Brobecker [this message]
2009-05-11 19:42 ` Daniel Jacobowitz
2009-05-11 20:40 ` Eli Zaretskii
2009-05-11 21:19 ` Joel Brobecker
2009-05-12 3:09 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090525072550.GF23016@adacore.com \
--to=brobecker@adacore.com \
--cc=drow@false.org \
--cc=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox