From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21888 invoked by alias); 25 May 2009 07:26:05 -0000 Received: (qmail 21865 invoked by uid 22791); 25 May 2009 07:26:04 -0000 X-SWARE-Spam-Status: No, hits=-2.4 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 25 May 2009 07:25:59 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 859562BAC2D; Mon, 25 May 2009 03:25:57 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id q75tbmCXqot3; Mon, 25 May 2009 03:25:57 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 36C5D2BAAD4; Mon, 25 May 2009 03:25:57 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id 04ED2F5965; Mon, 25 May 2009 09:25:51 +0200 (CEST) Date: Mon, 25 May 2009 07:26:00 -0000 From: Joel Brobecker To: Eli Zaretskii Cc: drow@false.org, gdb-patches@sourceware.org Subject: Re: [RFA] Fix "break foo" when `foo's prologue ends before line table Message-ID: <20090525072550.GF23016@adacore.com> References: <83skjebbef.fsf@gnu.org> <20090511125644.GD14773@adacore.com> <83zldjxzzr.fsf@gnu.org> <20090511192709.GG14773@adacore.com> <83tz3rxt4p.fsf@gnu.org> <83eiupqos5.fsf@gnu.org> <20090520211631.GD16152@adacore.com> <83k548t94h.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <83k548t94h.fsf@gnu.org> User-Agent: Mutt/1.5.18 (2008-05-17) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-05/txt/msg00542.txt.bz2 > > > + /* Linetable entries are ordered by PC values, see the commentary in > > ^^^^^^ comment > > Hmm? are you saying that "commentary" is incorrect English? If so, I > beg to differ. ;-) It seems to me that "commentary" would be used in a different context, not to refer to some text describing what a piece of code does. But I'm not a native English speaker, so I might be wrong. > Is the comment I added before the call to skip_prologue_using_lineinfo > good enough? It looks great to me :) -- Joel