Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Daniel Jacobowitz <drow@false.org>
To: Eli Zaretskii <eliz@gnu.org>
Cc: Joel Brobecker <brobecker@adacore.com>, gdb-patches@sourceware.org
Subject: Re: [RFA] Fix "break foo" when `foo's prologue ends before line 	table
Date: Mon, 11 May 2009 21:20:00 -0000	[thread overview]
Message-ID: <20090511212006.GA16436@caradoc.them.org> (raw)
In-Reply-To: <83tz3rxt4p.fsf@gnu.org>

On Mon, May 11, 2009 at 11:49:10PM +0300, Eli Zaretskii wrote:
> Are such rearrangements permitted?  I mean, are we talking about a
> real-life situation here?

Definitely.  This happens all the time.

> > Do you really want "break foo" to break on the line where a () is
> > called?
> 
> It's hard to say, really.  There are arguments for both, but I
> personally tend to think that stopping on the call to `a' is what I'd
> want.
> 
> What do others think?

I agree with Pedro.  When the compiler moves something into the
prologue, generally, we try to stop on it - even if the prologue is
not yet finished.

> > /* The order of entries in the linetable is significant.  They should
> >    be sorted by increasing values of the pc field.
> 
> Well, granted, I've seen that comment.  But (a) are we sure all of our
> comments are necessarily accurate to rely on them?, and (b) it
> continues to say

This data structure relies on being sorted by PC.  You can see e.g. in
find_pc_sect_line.

-- 
Daniel Jacobowitz
CodeSourcery


  reply	other threads:[~2009-05-11 21:20 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-05-09 14:26 Eli Zaretskii
2009-05-11 12:56 ` Joel Brobecker
2009-05-11 18:21   ` Eli Zaretskii
2009-05-11 19:27     ` Joel Brobecker
2009-05-11 20:49       ` Eli Zaretskii
2009-05-11 21:20         ` Daniel Jacobowitz [this message]
2009-05-12  3:13           ` Eli Zaretskii
2009-05-11 21:28         ` Joel Brobecker
2009-05-16 11:18         ` Eli Zaretskii
2009-05-20 23:07           ` Joel Brobecker
2009-05-23 10:20             ` Eli Zaretskii
2009-05-25  7:26               ` Joel Brobecker
2009-05-11 19:42 ` Daniel Jacobowitz
2009-05-11 20:40   ` Eli Zaretskii
2009-05-11 21:19     ` Joel Brobecker
2009-05-12  3:09       ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090511212006.GA16436@caradoc.them.org \
    --to=drow@false.org \
    --cc=brobecker@adacore.com \
    --cc=eliz@gnu.org \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox