From: Joel Brobecker <brobecker@adacore.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: Daniel Jacobowitz <drow@false.org>, gdb-patches@sourceware.org
Subject: Re: [RFA] Fix "break foo" when `foo's prologue ends before line table
Date: Mon, 11 May 2009 21:19:00 -0000 [thread overview]
Message-ID: <20090511211855.GA7584@adacore.com> (raw)
In-Reply-To: <83vdo7xtk1.fsf@gnu.org>
> I would think so. What I show in my mail comes from "maint print
> symbols", so I have no reason to believe the lineinfo table does not
> reflect the COFF debug info.
You should be able to find another confirmation of this by looking
at the .s file. I don't know what assembler directive is used on
DJGPP to emit lines, but it's usually straightforward.
> Maybe. But the lines before that are just decorations, from the
> > Is it possible to patch this up in the coff line table reader?
>
> What, by inventing extra entries in the table? That could be
> dangerous, since we would be doing that without any clear idea of the
> code between 0x172c and 0x1748.
I don't think it matters what the code does, since otherwise you
would skip that code before inserting the breakpoint anyway.
> Even if we could, is that really better than the approach I suggested?
Not sure if this is better or not. The advantage of this approach is
that we protect other platforms from this form of debugging info -
one could argue that it's incomplete.
--
Joel
next prev parent reply other threads:[~2009-05-11 21:19 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-09 14:26 Eli Zaretskii
2009-05-11 12:56 ` Joel Brobecker
2009-05-11 18:21 ` Eli Zaretskii
2009-05-11 19:27 ` Joel Brobecker
2009-05-11 20:49 ` Eli Zaretskii
2009-05-11 21:20 ` Daniel Jacobowitz
2009-05-12 3:13 ` Eli Zaretskii
2009-05-11 21:28 ` Joel Brobecker
2009-05-16 11:18 ` Eli Zaretskii
2009-05-20 23:07 ` Joel Brobecker
2009-05-23 10:20 ` Eli Zaretskii
2009-05-25 7:26 ` Joel Brobecker
2009-05-11 19:42 ` Daniel Jacobowitz
2009-05-11 20:40 ` Eli Zaretskii
2009-05-11 21:19 ` Joel Brobecker [this message]
2009-05-12 3:09 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090511211855.GA7584@adacore.com \
--to=brobecker@adacore.com \
--cc=drow@false.org \
--cc=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox