[RFA] Fix nits in linux-x86-low.c

[RFA] Fix nits in linux-x86-low.c

[Doug Evans]

Hi.

Sorry 'bout that.  Ok to check in?

2009-05-13  Doug Evans  <dje@google.com>

	* linux-x86-low.c: Don't include assert.h.
	(x86_siginfo_fixup): Use fatal, not assert.
	(x86_arch_setup): Fix comment.

Index: linux-x86-low.c
===================================================================
RCS file: /cvs/src/src/gdb/gdbserver/linux-x86-low.c,v
retrieving revision 1.1
diff -u -p -u -p -r1.1 linux-x86-low.c
--- linux-x86-low.c	12 May 2009 22:25:00 -0000	1.1
+++ linux-x86-low.c	13 May 2009 17:58:53 -0000
@@ -18,7 +18,6 @@
    You should have received a copy of the GNU General Public License
    along with this program.  If not, see <http://www.gnu.org/licenses/>.  */
 
-#include <assert.h>
 #include <signal.h>
 #include "server.h"
 #include "linux-low.h"
@@ -551,7 +550,8 @@ x86_siginfo_fixup (struct siginfo *nativ
   /* Is the inferior 32-bit?  If so, then fixup the siginfo object.  */
   if (register_size (0) == 4)
     {
-      assert (sizeof (struct siginfo) == sizeof (compat_siginfo_t));
+      if (sizeof (struct siginfo) != sizeof (compat_siginfo_t))
+	fatal ("unexpected difference in siginfo");
 
       if (direction == 0)
 	compat_siginfo_from_siginfo ((struct compat_siginfo *) inf, native);
@@ -565,7 +565,7 @@ x86_siginfo_fixup (struct siginfo *nativ
   return 0;
 }
 \f
-/* Return non-zero if the target is 64-bit.  */
+/* Initialize gdbserver for the architecture of the inferior.  */
 
 static void
 x86_arch_setup (void)

Re: [RFA] Fix nits in linux-x86-low.c

[Pedro Alves]

On Wednesday 13 May 2009 19:04:28, Doug Evans wrote:
> Hi.
> 
> Sorry 'bout that.  Ok to check in?

Sure, thanks much!

-- 
Pedro Alves