From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25463 invoked by alias); 13 May 2009 18:04:54 -0000 Received: (qmail 25210 invoked by uid 22791); 13 May 2009 18:04:52 -0000 X-SWARE-Spam-Status: No, hits=-2.2 required=5.0 tests=AWL,BAYES_00,SPF_PASS X-Spam-Check-By: sourceware.org Received: from smtp-out.google.com (HELO smtp-out.google.com) (216.239.33.17) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 13 May 2009 18:04:46 +0000 Received: from zps18.corp.google.com (zps18.corp.google.com [172.25.146.18]) by smtp-out.google.com with ESMTP id n4DI4UQs009413; Wed, 13 May 2009 19:04:30 +0100 Received: from localhost (ruffy.mtv.corp.google.com [172.18.118.116]) by zps18.corp.google.com with ESMTP id n4DI4SBH003141; Wed, 13 May 2009 11:04:28 -0700 Received: by localhost (Postfix, from userid 67641) id 4F70984890; Wed, 13 May 2009 11:04:28 -0700 (PDT) To: pedro@codesourcery.com, gdb-patches@sourceware.org Subject: [RFA] Fix nits in linux-x86-low.c Message-Id: <20090513180428.4F70984890@localhost> Date: Wed, 13 May 2009 18:04:00 -0000 From: dje@google.com (Doug Evans) X-System-Of-Record: true X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-05/txt/msg00276.txt.bz2 Hi. Sorry 'bout that. Ok to check in? 2009-05-13 Doug Evans * linux-x86-low.c: Don't include assert.h. (x86_siginfo_fixup): Use fatal, not assert. (x86_arch_setup): Fix comment. Index: linux-x86-low.c =================================================================== RCS file: /cvs/src/src/gdb/gdbserver/linux-x86-low.c,v retrieving revision 1.1 diff -u -p -u -p -r1.1 linux-x86-low.c --- linux-x86-low.c 12 May 2009 22:25:00 -0000 1.1 +++ linux-x86-low.c 13 May 2009 17:58:53 -0000 @@ -18,7 +18,6 @@ You should have received a copy of the GNU General Public License along with this program. If not, see . */ -#include #include #include "server.h" #include "linux-low.h" @@ -551,7 +550,8 @@ x86_siginfo_fixup (struct siginfo *nativ /* Is the inferior 32-bit? If so, then fixup the siginfo object. */ if (register_size (0) == 4) { - assert (sizeof (struct siginfo) == sizeof (compat_siginfo_t)); + if (sizeof (struct siginfo) != sizeof (compat_siginfo_t)) + fatal ("unexpected difference in siginfo"); if (direction == 0) compat_siginfo_from_siginfo ((struct compat_siginfo *) inf, native); @@ -565,7 +565,7 @@ x86_siginfo_fixup (struct siginfo *nativ return 0; } -/* Return non-zero if the target is 64-bit. */ +/* Initialize gdbserver for the architecture of the inferior. */ static void x86_arch_setup (void)