From: dje@google.com (Doug Evans)
To: pedro@codesourcery.com, gdb-patches@sourceware.org
Subject: [RFA] Fix nits in linux-x86-low.c
Date: Wed, 13 May 2009 18:04:00 -0000 [thread overview]
Message-ID: <20090513180428.4F70984890@localhost> (raw)
Hi.
Sorry 'bout that. Ok to check in?
2009-05-13 Doug Evans <dje@google.com>
* linux-x86-low.c: Don't include assert.h.
(x86_siginfo_fixup): Use fatal, not assert.
(x86_arch_setup): Fix comment.
Index: linux-x86-low.c
===================================================================
RCS file: /cvs/src/src/gdb/gdbserver/linux-x86-low.c,v
retrieving revision 1.1
diff -u -p -u -p -r1.1 linux-x86-low.c
--- linux-x86-low.c 12 May 2009 22:25:00 -0000 1.1
+++ linux-x86-low.c 13 May 2009 17:58:53 -0000
@@ -18,7 +18,6 @@
You should have received a copy of the GNU General Public License
along with this program. If not, see <http://www.gnu.org/licenses/>. */
-#include <assert.h>
#include <signal.h>
#include "server.h"
#include "linux-low.h"
@@ -551,7 +550,8 @@ x86_siginfo_fixup (struct siginfo *nativ
/* Is the inferior 32-bit? If so, then fixup the siginfo object. */
if (register_size (0) == 4)
{
- assert (sizeof (struct siginfo) == sizeof (compat_siginfo_t));
+ if (sizeof (struct siginfo) != sizeof (compat_siginfo_t))
+ fatal ("unexpected difference in siginfo");
if (direction == 0)
compat_siginfo_from_siginfo ((struct compat_siginfo *) inf, native);
@@ -565,7 +565,7 @@ x86_siginfo_fixup (struct siginfo *nativ
return 0;
}
\f
-/* Return non-zero if the target is 64-bit. */
+/* Initialize gdbserver for the architecture of the inferior. */
static void
x86_arch_setup (void)
next reply other threads:[~2009-05-13 18:04 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-13 18:04 Doug Evans [this message]
2009-05-13 19:01 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090513180428.4F70984890@localhost \
--to=dje@google.com \
--cc=gdb-patches@sourceware.org \
--cc=pedro@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox