From: Pedro Alves <pedro@codesourcery.com>
To: gdb-patches@sourceware.org
Cc: Vladimir Prus <vladimir@codesourcery.com>,
gdb-patches@sources.redhat.com,
Nick Roberts <nickrob@snap.net.nz>
Subject: Re: [RFC] Fix MI timings
Date: Mon, 09 Mar 2009 21:36:00 -0000 [thread overview]
Message-ID: <200903092136.34537.pedro@codesourcery.com> (raw)
In-Reply-To: <200903100032.25610.vladimir@codesourcery.com>
On Monday 09 March 2009 21:32:25, Vladimir Prus wrote:
> +void mi_print_timing_maybe ();
^ (void) here too, please.
Also, it's redundant, but the only other function declared
in the header marks it explicitly as "extern", you may want
to do the same for consistency.
--
Pedro Alves
WARNING: multiple messages have this Message-ID
From: Pedro Alves <pedro@codesourcery.com>
To: gdb-patches@sourceware.org
Cc: Vladimir Prus <vladimir@codesourcery.com>,
gdb-patches@sources.redhat.com,
Nick Roberts <nickrob@snap.net.nz>
Subject: Re: [RFC] Fix MI timings
Date: Mon, 09 Mar 2009 22:07:00 -0000 [thread overview]
Message-ID: <200903092136.34537.pedro@codesourcery.com> (raw)
Message-ID: <20090309220700.tICZaGLmupCNTiQDiWxaFjQEvYUsdEitM8AHpX0wef4@z> (raw)
In-Reply-To: <200903100032.25610.vladimir@codesourcery.com>
On Monday 09 March 2009 21:32:25, Vladimir Prus wrote:
> +void mi_print_timing_maybe ();
^ (void) here too, please.
Also, it's redundant, but the only other function declared
in the header marks it explicitly as "extern", you may want
to do the same for consistency.
--
Pedro Alves
next prev parent reply other threads:[~2009-03-09 21:36 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-09 21:10 Vladimir Prus
2009-03-09 21:15 ` Vladimir Prus
2009-03-09 21:22 ` Daniel Jacobowitz
2009-03-09 21:32 ` Vladimir Prus
2009-03-09 21:36 ` Pedro Alves [this message]
2009-03-09 22:07 ` Pedro Alves
2009-03-17 5:27 ` Pedro Alves
2009-03-17 7:26 ` Vladimir Prus
2009-03-17 8:03 ` Vladimir Prus
2009-03-13 7:59 ` Vladimir Prus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200903092136.34537.pedro@codesourcery.com \
--to=pedro@codesourcery.com \
--cc=gdb-patches@sources.redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=nickrob@snap.net.nz \
--cc=vladimir@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox