From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5109 invoked by alias); 9 Mar 2009 21:36:43 -0000 Received: (qmail 5101 invoked by uid 22791); 9 Mar 2009 21:36:43 -0000 X-SWARE-Spam-Status: No, hits=-2.4 required=5.0 tests=AWL,BAYES_00,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (65.74.133.4) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 09 Mar 2009 21:36:39 +0000 Received: (qmail 27597 invoked from network); 9 Mar 2009 21:36:35 -0000 Received: from unknown (HELO orlando.local) (pedro@127.0.0.2) by mail.codesourcery.com with ESMTPA; 9 Mar 2009 21:36:35 -0000 From: Pedro Alves To: gdb-patches@sourceware.org Subject: Re: [RFC] Fix MI timings Date: Mon, 09 Mar 2009 21:36:00 -0000 User-Agent: KMail/1.9.10 Cc: Vladimir Prus , gdb-patches@sources.redhat.com, Nick Roberts References: <200903100010.06180.vladimir@codesourcery.com> <20090309212230.GA17609@caradoc.them.org> <200903100032.25610.vladimir@codesourcery.com> In-Reply-To: <200903100032.25610.vladimir@codesourcery.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200903092136.34537.pedro@codesourcery.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-03/txt/msg00130.txt.bz2 On Monday 09 March 2009 21:32:25, Vladimir Prus wrote: > +void mi_print_timing_maybe (); ^ (void) here too, please. Also, it's redundant, but the only other function declared in the header marks it explicitly as "extern", you may want to do the same for consistency. -- Pedro Alves From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5431 invoked by alias); 9 Mar 2009 21:36:45 -0000 Received: (qmail 5417 invoked by uid 22791); 9 Mar 2009 21:36:45 -0000 X-SWARE-Spam-Status: No, hits=-2.4 required=5.0 tests=AWL,BAYES_00,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (65.74.133.4) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 09 Mar 2009 21:36:39 +0000 Received: (qmail 27597 invoked from network); 9 Mar 2009 21:36:35 -0000 Received: from unknown (HELO orlando.local) (pedro@127.0.0.2) by mail.codesourcery.com with ESMTPA; 9 Mar 2009 21:36:35 -0000 From: Pedro Alves To: gdb-patches@sourceware.org Subject: Re: [RFC] Fix MI timings Date: Mon, 09 Mar 2009 22:07:00 -0000 User-Agent: KMail/1.9.10 Cc: Vladimir Prus , gdb-patches@sources.redhat.com, Nick Roberts References: <200903100010.06180.vladimir@codesourcery.com> <20090309212230.GA17609@caradoc.them.org> <200903100032.25610.vladimir@codesourcery.com> In-Reply-To: <200903100032.25610.vladimir@codesourcery.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-ID: <200903092136.34537.pedro@codesourcery.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-03/txt/msg00131.txt.bz2 Message-ID: <20090309220700.tICZaGLmupCNTiQDiWxaFjQEvYUsdEitM8AHpX0wef4@z> On Monday 09 March 2009 21:32:25, Vladimir Prus wrote: > +void mi_print_timing_maybe (); ^ (void) here too, please. Also, it's redundant, but the only other function declared in the header marks it explicitly as "extern", you may want to do the same for consistency. -- Pedro Alves