Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Vladimir Prus <vladimir@codesourcery.com>
To: gdb-patches@sources.redhat.com,  Nick Roberts <nickrob@snap.net.nz>
Subject: [RFC] Fix MI timings
Date: Mon, 09 Mar 2009 21:10:00 -0000	[thread overview]
Message-ID: <200903100010.06180.vladimir@codesourcery.com> (raw)


I've noticed that -enable-timings produces broken output for all
commands that resume target. First, we output *stopped.
And them on a separate line we print the timing, like this:

	,time={wallclock="0.32046",user="0.32000",system="0.00000"} (gdb)

This happens because mi_on_normal_stop does print newline, and then
mi_execute_async_cli_command does timings separately. This patch:

1. Make mi_on_normal_stop emit the timing info
2. Stop mi_execute_async_cli_command from doing so
3. Makes captured_mi_execute_command report timing both to MI
and CLI code paths.

I'll commit this in a few days if there are no objections.

- Volodya


             reply	other threads:[~2009-03-09 21:10 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-03-09 21:10 Vladimir Prus [this message]
2009-03-09 21:15 ` Vladimir Prus
2009-03-09 21:22   ` Daniel Jacobowitz
2009-03-09 21:32     ` Vladimir Prus
2009-03-09 21:36       ` Pedro Alves
2009-03-09 22:07         ` Pedro Alves
2009-03-17  5:27         ` Pedro Alves
2009-03-17  7:26           ` Vladimir Prus
2009-03-17  8:03             ` Vladimir Prus
2009-03-13  7:59       ` Vladimir Prus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200903100010.06180.vladimir@codesourcery.com \
    --to=vladimir@codesourcery.com \
    --cc=gdb-patches@sources.redhat.com \
    --cc=nickrob@snap.net.nz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox