From: Pedro Alves <pedro@codesourcery.com>
To: gdb-patches@sourceware.org
Cc: Vladimir Prus <vladimir@codesourcery.com>,
Eli Zaretskii <eliz@gnu.org>,
drow@false.org, gdb-patches@sources.redhat.com,
nickrob@snap.net.nz
Subject: Re: MI solib notification
Date: Tue, 17 Feb 2009 22:10:00 -0000 [thread overview]
Message-ID: <200902172159.30375.pedro@codesourcery.com> (raw)
In-Reply-To: <200902172244.48437.vladimir@codesourcery.com>
On Tuesday 17 February 2009 19:44:48, Vladimir Prus wrote:
> @@ -4457,6 +4457,14 @@ disable_breakpoints_in_unloaded_shlib (struct so_list *solib)
> struct bp_location *loc;
> int disabled_shlib_breaks = 0;
>
> + /* SunOS a.out shared libraries are always mapped, so do not
> + disable breakpoints; they will only be reported as unloaded
> + through clear_solib when GDB discards its shared library
> + list. See clear_solib for more information. */
> + if (exec_bfd != NULL
> + && bfd_get_flavour (exec_bfd) != bfd_target_aout_flavour)
> + return;
> +
Isn't this check backwards?
--
Pedro Alves
WARNING: multiple messages have this Message-ID
From: Pedro Alves <pedro@codesourcery.com>
To: gdb-patches@sourceware.org
Cc: Vladimir Prus <vladimir@codesourcery.com>,
Eli Zaretskii <eliz@gnu.org>,
drow@false.org, gdb-patches@sources.redhat.com,
nickrob@snap.net.nz
Subject: Re: MI solib notification
Date: Wed, 18 Feb 2009 02:01:00 -0000 [thread overview]
Message-ID: <200902172159.30375.pedro@codesourcery.com> (raw)
Message-ID: <20090218020100.RvDm8wzERWQhpfAFCxcwz3IPhOxuCSfRxSQlSRwb_aM@z> (raw)
In-Reply-To: <200902172244.48437.vladimir@codesourcery.com>
On Tuesday 17 February 2009 19:44:48, Vladimir Prus wrote:
> @@ -4457,6 +4457,14 @@ disable_breakpoints_in_unloaded_shlib (struct so_list *solib)
> struct bp_location *loc;
> int disabled_shlib_breaks = 0;
>
> + /* SunOS a.out shared libraries are always mapped, so do not
> + disable breakpoints; they will only be reported as unloaded
> + through clear_solib when GDB discards its shared library
> + list. See clear_solib for more information. */
> + if (exec_bfd != NULL
> + && bfd_get_flavour (exec_bfd) != bfd_target_aout_flavour)
> + return;
> +
Isn't this check backwards?
--
Pedro Alves
next prev parent reply other threads:[~2009-02-17 21:59 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-30 23:44 Vladimir Prus
[not found] ` <utz7gzcmo.fsf@gnu.org>
2009-02-01 17:53 ` Daniel Jacobowitz
2009-02-01 18:22 ` Eli Zaretskii
2009-02-01 18:29 ` Daniel Jacobowitz
2009-02-17 19:09 ` Vladimir Prus
2009-02-17 19:45 ` Eli Zaretskii
2009-02-17 19:49 ` Vladimir Prus
2009-02-17 20:30 ` Eli Zaretskii
2009-02-17 21:45 ` Vladimir Prus
2009-02-17 21:59 ` Vladimir Prus
2009-02-18 7:31 ` Eli Zaretskii
2009-02-18 10:19 ` Vladimir Prus
2009-02-18 19:53 ` Eli Zaretskii
2009-02-18 20:04 ` Vladimir Prus
2009-02-18 22:28 ` Eli Zaretskii
2009-02-18 4:24 ` Eli Zaretskii
2009-02-17 21:37 ` Daniel Jacobowitz
2009-02-17 22:10 ` Pedro Alves [this message]
2009-02-18 2:01 ` Pedro Alves
2009-02-01 18:04 ` Daniel Jacobowitz
2009-02-12 9:12 ` Vladimir Prus
2009-02-12 13:22 ` Daniel Jacobowitz
2009-02-12 15:02 ` Vladimir Prus
2009-02-12 15:13 ` Daniel Jacobowitz
2009-02-12 17:35 ` Tom Tromey
2009-02-12 18:02 ` Daniel Jacobowitz
2009-02-12 20:11 ` Tom Tromey
2009-02-12 20:17 ` Vladimir Prus
2009-02-12 20:26 ` Daniel Jacobowitz
2009-02-17 19:08 ` Vladimir Prus
2009-02-12 18:06 ` Pedro Alves
2009-02-12 19:45 ` Pedro Alves
2009-02-12 19:56 ` Tom Tromey
2009-02-12 19:58 ` Daniel Jacobowitz
2009-02-13 2:22 ` Joel Brobecker
2009-02-01 18:47 ` Daniel Jacobowitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200902172159.30375.pedro@codesourcery.com \
--to=pedro@codesourcery.com \
--cc=drow@false.org \
--cc=eliz@gnu.org \
--cc=gdb-patches@sources.redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=nickrob@snap.net.nz \
--cc=vladimir@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox