From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14715 invoked by alias); 17 Feb 2009 21:59:39 -0000 Received: (qmail 14705 invoked by uid 22791); 17 Feb 2009 21:59:38 -0000 X-SWARE-Spam-Status: No, hits=-2.1 required=5.0 tests=AWL,BAYES_00,J_CHICKENPOX_13,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (65.74.133.4) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 17 Feb 2009 21:59:34 +0000 Received: (qmail 14844 invoked from network); 17 Feb 2009 21:59:31 -0000 Received: from unknown (HELO orlando) (pedro@127.0.0.2) by mail.codesourcery.com with ESMTPA; 17 Feb 2009 21:59:31 -0000 From: Pedro Alves To: gdb-patches@sourceware.org Subject: Re: MI solib notification Date: Tue, 17 Feb 2009 22:10:00 -0000 User-Agent: KMail/1.9.10 Cc: Vladimir Prus , Eli Zaretskii , drow@false.org, gdb-patches@sources.redhat.com, nickrob@snap.net.nz References: <200901310010.46738.vladimir@codesourcery.com> <200902172244.48437.vladimir@codesourcery.com> In-Reply-To: <200902172244.48437.vladimir@codesourcery.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200902172159.30375.pedro@codesourcery.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-02/txt/msg00370.txt.bz2 On Tuesday 17 February 2009 19:44:48, Vladimir Prus wrote: > @@ -4457,6 +4457,14 @@ disable_breakpoints_in_unloaded_shlib (struct so_list *solib) > struct bp_location *loc; > int disabled_shlib_breaks = 0; > > + /* SunOS a.out shared libraries are always mapped, so do not > + disable breakpoints; they will only be reported as unloaded > + through clear_solib when GDB discards its shared library > + list. See clear_solib for more information. */ > + if (exec_bfd != NULL > + && bfd_get_flavour (exec_bfd) != bfd_target_aout_flavour) > + return; > + Isn't this check backwards? -- Pedro Alves From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14730 invoked by alias); 17 Feb 2009 21:59:40 -0000 Received: (qmail 14714 invoked by uid 22791); 17 Feb 2009 21:59:39 -0000 X-SWARE-Spam-Status: No, hits=-2.1 required=5.0 tests=AWL,BAYES_00,J_CHICKENPOX_13,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (65.74.133.4) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 17 Feb 2009 21:59:33 +0000 Received: (qmail 14844 invoked from network); 17 Feb 2009 21:59:31 -0000 Received: from unknown (HELO orlando) (pedro@127.0.0.2) by mail.codesourcery.com with ESMTPA; 17 Feb 2009 21:59:31 -0000 From: Pedro Alves To: gdb-patches@sourceware.org Subject: Re: MI solib notification Date: Wed, 18 Feb 2009 02:01:00 -0000 User-Agent: KMail/1.9.10 Cc: Vladimir Prus , Eli Zaretskii , drow@false.org, gdb-patches@sources.redhat.com, nickrob@snap.net.nz References: <200901310010.46738.vladimir@codesourcery.com> <200902172244.48437.vladimir@codesourcery.com> In-Reply-To: <200902172244.48437.vladimir@codesourcery.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-ID: <200902172159.30375.pedro@codesourcery.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-02/txt/msg00371.txt.bz2 Message-ID: <20090218020100.RvDm8wzERWQhpfAFCxcwz3IPhOxuCSfRxSQlSRwb_aM@z> On Tuesday 17 February 2009 19:44:48, Vladimir Prus wrote: > @@ -4457,6 +4457,14 @@ disable_breakpoints_in_unloaded_shlib (struct so_list *solib) > struct bp_location *loc; > int disabled_shlib_breaks = 0; > > + /* SunOS a.out shared libraries are always mapped, so do not > + disable breakpoints; they will only be reported as unloaded > + through clear_solib when GDB discards its shared library > + list. See clear_solib for more information. */ > + if (exec_bfd != NULL > + && bfd_get_flavour (exec_bfd) != bfd_target_aout_flavour) > + return; > + Isn't this check backwards? -- Pedro Alves