[RFA] Document fallback behavior for target_so_ops same.

[RFA] Document fallback behavior for target_so_ops same.

[Tristan Gingold]

Hi,

as indicated by Joel, solib has a fallback if 'same' target_so_op is  
not set.  This patch documents
it.

Tristan.

2009-02-03  Tristan Gingold  <gingold@adacore.com>

	* solist.h (struct target_so_ops): Comment fallback behavior for
	operation same.

diff -u -r1.23 solist.h
--- solist.h	15 Jan 2009 16:35:22 -0000	1.23
+++ solist.h	3 Feb 2009 12:51:17 -0000
@@ -119,7 +119,8 @@

      /* Given two so_list objects, one from the GDB thread list
         and another from the list returned by current_sos, return 1
-       if they represent the same library.  */
+       if they represent the same library.
+       Falls back to using strcmp on so_original_name field.  */
      int (*same) (struct so_list *gdb, struct so_list *inferior);
    };

Re: [RFA] Document fallback behavior for target_so_ops same.

[Joel Brobecker]

> 2009-02-03  Tristan Gingold  <gingold@adacore.com>
> 
> 	* solist.h (struct target_so_ops): Comment fallback behavior for
> 	operation same.

Thanks for sending the patch. This is OK, with just one tiny request:

> diff -u -r1.23 solist.h
> --- solist.h	15 Jan 2009 16:35:22 -0000	1.23
> +++ solist.h	3 Feb 2009 12:51:17 -0000
> @@ -119,7 +119,8 @@
> 
>      /* Given two so_list objects, one from the GDB thread list
>         and another from the list returned by current_sos, return 1
> -       if they represent the same library.  */
> +       if they represent the same library.
> +       Falls back to using strcmp on so_original_name field.  */

Can you add "when set to NULL" at the end of your new sentence?

          Falls back to using strcmp on so_original_name field
          when set to NULL.

Thanks,
-- 
Joel

Re: [RFA] Document fallback behavior for target_so_ops same.

[Tristan Gingold]

On Feb 3, 2009, at 5:36 PM, Joel Brobecker wrote:
> Can you add "when set to NULL" at the end of your new sentence?
>
>          Falls back to using strcmp on so_original_name field
>          when set to NULL.

Committed with this sentence.  Thanks

Tristan.