Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Joel Brobecker <brobecker@adacore.com>
To: Tristan Gingold <gingold@adacore.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [RFA] Document fallback behavior for target_so_ops same.
Date: Tue, 03 Feb 2009 16:36:00 -0000	[thread overview]
Message-ID: <20090203163627.GE3964@adacore.com> (raw)
In-Reply-To: <23511769-09D5-4558-A38F-B6ECC376C2FA@adacore.com>

> 2009-02-03  Tristan Gingold  <gingold@adacore.com>
> 
> 	* solist.h (struct target_so_ops): Comment fallback behavior for
> 	operation same.

Thanks for sending the patch. This is OK, with just one tiny request:

> diff -u -r1.23 solist.h
> --- solist.h	15 Jan 2009 16:35:22 -0000	1.23
> +++ solist.h	3 Feb 2009 12:51:17 -0000
> @@ -119,7 +119,8 @@
> 
>      /* Given two so_list objects, one from the GDB thread list
>         and another from the list returned by current_sos, return 1
> -       if they represent the same library.  */
> +       if they represent the same library.
> +       Falls back to using strcmp on so_original_name field.  */

Can you add "when set to NULL" at the end of your new sentence?

          Falls back to using strcmp on so_original_name field
          when set to NULL.

Thanks,
-- 
Joel


  reply	other threads:[~2009-02-03 16:36 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-02-03 12:53 Tristan Gingold
2009-02-03 16:36 ` Joel Brobecker [this message]
2009-02-04  8:43   ` Tristan Gingold

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090203163627.GE3964@adacore.com \
    --to=brobecker@adacore.com \
    --cc=gdb-patches@sourceware.org \
    --cc=gingold@adacore.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox