From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12791 invoked by alias); 3 Feb 2009 16:36:38 -0000 Received: (qmail 12779 invoked by uid 22791); 3 Feb 2009 16:36:37 -0000 X-SWARE-Spam-Status: No, hits=-2.4 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 03 Feb 2009 16:36:32 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id BD7DF2A9611; Tue, 3 Feb 2009 11:36:30 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id IvEjziVwhVOn; Tue, 3 Feb 2009 11:36:30 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 883532A9600; Tue, 3 Feb 2009 11:36:30 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id DC697E7ACD; Tue, 3 Feb 2009 08:36:27 -0800 (PST) Date: Tue, 03 Feb 2009 16:36:00 -0000 From: Joel Brobecker To: Tristan Gingold Cc: gdb-patches@sourceware.org Subject: Re: [RFA] Document fallback behavior for target_so_ops same. Message-ID: <20090203163627.GE3964@adacore.com> References: <23511769-09D5-4558-A38F-B6ECC376C2FA@adacore.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <23511769-09D5-4558-A38F-B6ECC376C2FA@adacore.com> User-Agent: Mutt/1.4.2.2i Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-02/txt/msg00062.txt.bz2 > 2009-02-03 Tristan Gingold > > * solist.h (struct target_so_ops): Comment fallback behavior for > operation same. Thanks for sending the patch. This is OK, with just one tiny request: > diff -u -r1.23 solist.h > --- solist.h 15 Jan 2009 16:35:22 -0000 1.23 > +++ solist.h 3 Feb 2009 12:51:17 -0000 > @@ -119,7 +119,8 @@ > > /* Given two so_list objects, one from the GDB thread list > and another from the list returned by current_sos, return 1 > - if they represent the same library. */ > + if they represent the same library. > + Falls back to using strcmp on so_original_name field. */ Can you add "when set to NULL" at the end of your new sentence? Falls back to using strcmp on so_original_name field when set to NULL. Thanks, -- Joel