Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Jan Kratochvil <jan.kratochvil@redhat.com>
To: Joel Brobecker <brobecker@adacore.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [RFA/win32] move win32_xfer_shared_library to (new) 	win32-tdep...
Date: Sun, 11 Jan 2009 15:59:00 -0000	[thread overview]
Message-ID: <20090111155801.GA18734@host0.dyn.jankratochvil.net> (raw)
In-Reply-To: <20090111132129.GS24105@adacore.com>

On Sun, 11 Jan 2009 14:21:29 +0100, Joel Brobecker wrote:
> Excellent! Thank you, Chris. The two patches have now been checked in.
> 
> > I don't know of any way to do a "mv" in CVS.  If no one objects, I'll do
> > some surgery on the CVS repository to make a copy of windows-nat.c
> > and windows-tdep.c to make it look like they always existed and then
> > I'll cvs delete the old files and change Makefile.in.
> 
> Thanks for taking care of that too. The files are ready for the "move".

x86_64-unknown-linux-gnu now fails using --enable-targets=all:
libgdb.a(i386-cygwin-tdep.o): In function `core_process_module_section':
.../gdb/i386-cygwin-tdep.c:160: undefined reference to `win32_xfer_shared_library'

Please apply possibly adjusted before/after the expected renaming.


Regards,
Jan


2009-01-11  Jan Kratochvil  <jan.kratochvil@redhat.com>

	Fix linking with --enable-targets=all:
	* Makefile.in (ALL_TARGET_OBS): Add win32-tdep.o.
	(HFILES_NO_SRCDIR): Add win32-tdep.h.
	(ALLDEPFILES): Add win32-tdep.c.

--- gdb/Makefile.in	9 Jan 2009 21:15:10 -0000	1.1063
+++ gdb/Makefile.in	11 Jan 2009 15:54:10 -0000
@@ -515,7 +515,8 @@ ALL_TARGET_OBS = \
 	xcoffread.o \
 	prologue-value.o \
 	symfile-mem.o \
-	corelow.o
+	corelow.o \
+	win32-tdep.o
 
 # Host-dependent makefile fragment comes in here.
 @host_makefile_frag@
@@ -727,7 +728,7 @@ config/sparc/nm-sol2.h config/nm-linux.h
 config/rs6000/nm-rs6000.h top.h bsd-kvm.h gdb-stabs.h reggroups.h \
 annotate.h sim-regno.h dictionary.h dfp.h main.h frame-unwind.h	\
 remote-fileio.h i386-linux-tdep.h vax-tdep.h objc-lang.h \
-sentinel-frame.h bcache.h symfile.h
+sentinel-frame.h bcache.h symfile.h win32-tdep.h
 
 # Header files that already have srcdir in them, or which are in objdir.
 
@@ -1340,7 +1341,7 @@ ALLDEPFILES = \
 	spu-linux-nat.c spu-tdep.c \
 	v850-tdep.c \
 	vax-nat.c vax-tdep.c vaxbsd-nat.c vaxnbsd-tdep.c \
-	win32-nat.c \
+	win32-nat.c win32-tdep.c \
 	xcoffread.c xcoffsolib.c \
 	xstormy16-tdep.c \
 	xtensa-tdep.c xtensa-config.c \


  reply	other threads:[~2009-01-11 15:59 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-01-10  9:09 Joel Brobecker
2009-01-10 16:51 ` Christopher Faylor
2009-01-11  4:19   ` Joel Brobecker
2009-01-11  4:24     ` Christopher Faylor
2009-01-11  6:29       ` Daniel Jacobowitz
2009-01-11 13:22       ` Joel Brobecker
2009-01-11 15:59         ` Jan Kratochvil [this message]
2009-01-11 18:37           ` Christopher Faylor
2009-01-12  1:11             ` Rename win32-* to windows-* Christopher Faylor
2009-01-12 19:42               ` Eli Zaretskii
2009-01-12 13:30             ` win32-nat.c to windows-nat.c rename Pierre Muller
2009-01-13 10:24               ` Joel Brobecker
2009-01-13 11:04                 ` Pierre Muller
2009-01-13 17:55                   ` Christopher Faylor

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090111155801.GA18734@host0.dyn.jankratochvil.net \
    --to=jan.kratochvil@redhat.com \
    --cc=brobecker@adacore.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox