From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30503 invoked by alias); 11 Jan 2009 15:59:08 -0000 Received: (qmail 30494 invoked by uid 22791); 11 Jan 2009 15:59:07 -0000 X-SWARE-Spam-Status: No, hits=-2.2 required=5.0 tests=AWL,BAYES_00,KAM_MX,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mx2.redhat.com (HELO mx2.redhat.com) (66.187.237.31) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sun, 11 Jan 2009 15:58:34 +0000 Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26]) by mx2.redhat.com (8.13.8/8.13.8) with ESMTP id n0BFw9j4022442; Sun, 11 Jan 2009 10:58:09 -0500 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx2.corp.redhat.com (8.13.1/8.13.1) with ESMTP id n0BFwAmD032189; Sun, 11 Jan 2009 10:58:10 -0500 Received: from host0.dyn.jankratochvil.net (sebastian-int.corp.redhat.com [172.16.52.221]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id n0BFw8dB002587; Sun, 11 Jan 2009 10:58:09 -0500 Received: from host0.dyn.jankratochvil.net (localhost [127.0.0.1]) by host0.dyn.jankratochvil.net (8.14.3/8.14.3) with ESMTP id n0BFw4MO018856; Sun, 11 Jan 2009 16:58:05 +0100 Received: (from jkratoch@localhost) by host0.dyn.jankratochvil.net (8.14.3/8.14.2/Submit) id n0BFw1Sb018852; Sun, 11 Jan 2009 16:58:01 +0100 Date: Sun, 11 Jan 2009 15:59:00 -0000 From: Jan Kratochvil To: Joel Brobecker Cc: gdb-patches@sourceware.org Subject: Re: [RFA/win32] move win32_xfer_shared_library to (new) win32-tdep... Message-ID: <20090111155801.GA18734@host0.dyn.jankratochvil.net> References: <20090110090843.GB29274@adacore.com> <20090110165031.GB24850@ednor.casa.cgf.cx> <20090111041848.GQ24105@adacore.com> <20090111042411.GA8509@ednor.casa.cgf.cx> <20090111132129.GS24105@adacore.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20090111132129.GS24105@adacore.com> User-Agent: Mutt/1.5.18 (2008-05-17) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-01/txt/msg00245.txt.bz2 On Sun, 11 Jan 2009 14:21:29 +0100, Joel Brobecker wrote: > Excellent! Thank you, Chris. The two patches have now been checked in. > > > I don't know of any way to do a "mv" in CVS. If no one objects, I'll do > > some surgery on the CVS repository to make a copy of windows-nat.c > > and windows-tdep.c to make it look like they always existed and then > > I'll cvs delete the old files and change Makefile.in. > > Thanks for taking care of that too. The files are ready for the "move". x86_64-unknown-linux-gnu now fails using --enable-targets=all: libgdb.a(i386-cygwin-tdep.o): In function `core_process_module_section': .../gdb/i386-cygwin-tdep.c:160: undefined reference to `win32_xfer_shared_library' Please apply possibly adjusted before/after the expected renaming. Regards, Jan 2009-01-11 Jan Kratochvil Fix linking with --enable-targets=all: * Makefile.in (ALL_TARGET_OBS): Add win32-tdep.o. (HFILES_NO_SRCDIR): Add win32-tdep.h. (ALLDEPFILES): Add win32-tdep.c. --- gdb/Makefile.in 9 Jan 2009 21:15:10 -0000 1.1063 +++ gdb/Makefile.in 11 Jan 2009 15:54:10 -0000 @@ -515,7 +515,8 @@ ALL_TARGET_OBS = \ xcoffread.o \ prologue-value.o \ symfile-mem.o \ - corelow.o + corelow.o \ + win32-tdep.o # Host-dependent makefile fragment comes in here. @host_makefile_frag@ @@ -727,7 +728,7 @@ config/sparc/nm-sol2.h config/nm-linux.h config/rs6000/nm-rs6000.h top.h bsd-kvm.h gdb-stabs.h reggroups.h \ annotate.h sim-regno.h dictionary.h dfp.h main.h frame-unwind.h \ remote-fileio.h i386-linux-tdep.h vax-tdep.h objc-lang.h \ -sentinel-frame.h bcache.h symfile.h +sentinel-frame.h bcache.h symfile.h win32-tdep.h # Header files that already have srcdir in them, or which are in objdir. @@ -1340,7 +1341,7 @@ ALLDEPFILES = \ spu-linux-nat.c spu-tdep.c \ v850-tdep.c \ vax-nat.c vax-tdep.c vaxbsd-nat.c vaxnbsd-tdep.c \ - win32-nat.c \ + win32-nat.c win32-tdep.c \ xcoffread.c xcoffsolib.c \ xstormy16-tdep.c \ xtensa-tdep.c xtensa-config.c \