Re: [RFA/win32] move win32_xfer_shared_library to (new) win32-tdep...

[Christopher Faylor <cgf-use-the-mailinglist-please@sourceware.org>]

On Sun, Jan 11, 2009 at 08:18:48AM +0400, Joel Brobecker wrote:
>> >This patch moves the win32_xfer_shared_library function to a file
>> >that is not specific to the target CPU.  I introduced win32-tdep,
>> >to follow the naming scheme used by win32-nat, even though these
>> >file can also work on 64bit windows.
>> 
>> If this file can work on 64 bit windows then it seems like it should be
>> renamed to something more generic rather than potentially duplicating
>> the same code in two places.
>> 
>> Should win32-nat.c just be renamed to windows-nat.c?
>
>I think this would be a good idea. Same for win32-tdep.
>
>I suggest I commit the two remaining patches as is, and then do
>the move as a separate step.  That way, I don't have to rework
>the patches after the move is done.

That's fine.

>In terms of the move itself, how do we want it to be done.
>CVS doesn't support moves per se. Usually, in my own little CVS
>repos where I don't use branches, I do a "mv" inside the CVS
>repository.  But I know that this brings its own problems.
>Should we use "cvs remove + cvs add"?

I don't know of any way to do a "mv" in CVS.  If no one objects, I'll do
some surgery on the CVS repository to make a copy of windows-nat.c
and windows-tdep.c to make it look like they always existed and then
I'll cvs delete the old files and change Makefile.in.

cgf