Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Joel Brobecker <brobecker@adacore.com>
To: gdb-patches@sourceware.org
Subject: Re: [RFA/win32] move win32_xfer_shared_library to (new) win32-tdep...
Date: Sun, 11 Jan 2009 04:19:00 -0000	[thread overview]
Message-ID: <20090111041848.GQ24105@adacore.com> (raw)
In-Reply-To: <20090110165031.GB24850@ednor.casa.cgf.cx>

> >This patch moves the win32_xfer_shared_library function to a file
> >that is not specific to the target CPU.  I introduced win32-tdep,
> >to follow the naming scheme used by win32-nat, even though these
> >file can also work on 64bit windows.
> 
> If this file can work on 64 bit windows then it seems like it should be
> renamed to something more generic rather than potentially duplicating
> the same code in two places.
> 
> Should win32-nat.c just be renamed to windows-nat.c?

I think this would be a good idea. Same for win32-tdep.

I suggest I commit the two remaining patches as is, and then do
the move as a separate step.  That way, I don't have to rework
the patches after the move is done.

In terms of the move itself, how do we want it to be done.
CVS doesn't support moves per se. Usually, in my own little CVS
repos where I don't use branches, I do a "mv" inside the CVS
repository.  But I know that this brings its own problems.
Should we use "cvs remove + cvs add"?

-- 
Joel


  reply	other threads:[~2009-01-11  4:19 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-01-10  9:09 Joel Brobecker
2009-01-10 16:51 ` Christopher Faylor
2009-01-11  4:19   ` Joel Brobecker [this message]
2009-01-11  4:24     ` Christopher Faylor
2009-01-11  6:29       ` Daniel Jacobowitz
2009-01-11 13:22       ` Joel Brobecker
2009-01-11 15:59         ` Jan Kratochvil
2009-01-11 18:37           ` Christopher Faylor
2009-01-12  1:11             ` Rename win32-* to windows-* Christopher Faylor
2009-01-12 19:42               ` Eli Zaretskii
2009-01-12 13:30             ` win32-nat.c to windows-nat.c rename Pierre Muller
2009-01-13 10:24               ` Joel Brobecker
2009-01-13 11:04                 ` Pierre Muller
2009-01-13 17:55                   ` Christopher Faylor

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090111041848.GQ24105@adacore.com \
    --to=brobecker@adacore.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox