From: Daniel Jacobowitz <drow@false.org>
To: Eli Zaretskii <eliz@gnu.org>
Cc: Joel Brobecker <brobecker@adacore.com>,
pedro@codesourcery.com, gdb-patches@sourceware.org
Subject: Re: PR7580 - Command to force abort when internal error
Date: Sat, 10 Jan 2009 06:34:00 -0000 [thread overview]
Message-ID: <20090110063414.GA29801@caradoc.them.org> (raw)
In-Reply-To: <uocygjl4g.fsf@gnu.org>
On Fri, Jan 09, 2009 at 10:10:55PM +0200, Eli Zaretskii wrote:
> > Date: Fri, 9 Jan 2009 22:29:14 +0400
> > From: Joel Brobecker <brobecker@adacore.com>
> > Cc: Pedro Alves <pedro@codesourcery.com>, gdb-patches@sourceware.org
> >
> > > > +const char internal_problem_ask[] = "ask";
> > > > +const char internal_problem_yes[] = "yes";
> > > > +const char internal_problem_no[] = "no";
> > >
> > > Don't we want these strings to be translatable? The questions we ask
> > > about what to do are.
> >
> > I would say no. These are arguments used in a command
>
> Then why use a string for that purpose? Someone, some day might be
> tempted to use that string in some prompt or message, at which point
> we lose.
That's how all enum commands in GDB are implemented at present;
see e.g. always_inserted_enums.
--
Daniel Jacobowitz
CodeSourcery
next prev parent reply other threads:[~2009-01-10 6:34 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-29 3:35 Pedro Alves
2008-12-29 4:41 ` Joel Brobecker
2008-12-29 14:27 ` Pedro Alves
2008-12-31 3:57 ` Joel Brobecker
2009-01-07 21:59 ` Pedro Alves
2009-01-09 14:25 ` Eli Zaretskii
2009-01-09 15:33 ` Andreas Schwab
2009-01-09 18:16 ` Eli Zaretskii
2009-01-09 20:01 ` Andreas Schwab
2009-01-09 20:07 ` Eli Zaretskii
2009-01-09 20:15 ` Andreas Schwab
2009-01-09 20:26 ` Eli Zaretskii
2009-01-09 21:37 ` Andreas Schwab
2009-01-10 9:04 ` Eli Zaretskii
2009-01-25 23:19 ` Pedro Alves
2009-01-26 3:53 ` Eli Zaretskii
2009-01-26 16:27 ` Pedro Alves
2009-01-09 18:29 ` Joel Brobecker
2009-01-09 20:11 ` Eli Zaretskii
2009-01-10 6:34 ` Daniel Jacobowitz [this message]
2009-01-09 20:36 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090110063414.GA29801@caradoc.them.org \
--to=drow@false.org \
--cc=brobecker@adacore.com \
--cc=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=pedro@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox