From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26337 invoked by alias); 10 Jan 2009 06:34:59 -0000 Received: (qmail 26329 invoked by uid 22791); 10 Jan 2009 06:34:59 -0000 X-SWARE-Spam-Status: No, hits=-2.5 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from NaN.false.org (HELO nan.false.org) (208.75.86.248) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sat, 10 Jan 2009 06:34:18 +0000 Received: from nan.false.org (localhost [127.0.0.1]) by nan.false.org (Postfix) with ESMTP id C0A9A10738; Sat, 10 Jan 2009 06:34:15 +0000 (GMT) Received: from caradoc.them.org (209.195.188.212.nauticom.net [209.195.188.212]) by nan.false.org (Postfix) with ESMTP id 6E5001062C; Sat, 10 Jan 2009 06:34:15 +0000 (GMT) Received: from drow by caradoc.them.org with local (Exim 4.69) (envelope-from ) id 1LLXQF-0007q3-00; Sat, 10 Jan 2009 01:34:15 -0500 Date: Sat, 10 Jan 2009 06:34:00 -0000 From: Daniel Jacobowitz To: Eli Zaretskii Cc: Joel Brobecker , pedro@codesourcery.com, gdb-patches@sourceware.org Subject: Re: PR7580 - Command to force abort when internal error Message-ID: <20090110063414.GA29801@caradoc.them.org> Mail-Followup-To: Eli Zaretskii , Joel Brobecker , pedro@codesourcery.com, gdb-patches@sourceware.org References: <200812290335.09199.pedro@codesourcery.com> <200812291426.59784.pedro@codesourcery.com> <20081231035705.GA31595@adacore.com> <200901072159.29879.pedro@codesourcery.com> <20090109182914.GM24105@adacore.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2008-05-11) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-01/txt/msg00215.txt.bz2 On Fri, Jan 09, 2009 at 10:10:55PM +0200, Eli Zaretskii wrote: > > Date: Fri, 9 Jan 2009 22:29:14 +0400 > > From: Joel Brobecker > > Cc: Pedro Alves , gdb-patches@sourceware.org > > > > > > +const char internal_problem_ask[] = "ask"; > > > > +const char internal_problem_yes[] = "yes"; > > > > +const char internal_problem_no[] = "no"; > > > > > > Don't we want these strings to be translatable? The questions we ask > > > about what to do are. > > > > I would say no. These are arguments used in a command > > Then why use a string for that purpose? Someone, some day might be > tempted to use that string in some prompt or message, at which point > we lose. That's how all enum commands in GDB are implemented at present; see e.g. always_inserted_enums. -- Daniel Jacobowitz CodeSourcery