Re: PR7580 - Command to force abort when internal error

Joel Brobecker
2008-12-31T03:57:59Z

> I looked around for other three-state commands, and didn't find
> reusable patterns, which made me drop the idea of
> generalizing this, but there's a chance I didn't look right.

I couldn't come up with other examples where this would be useful
either. But it's always easy to factorize it if we find some later.

> I think the best is to make this an enum command with
> the three options ask|on|off, or perhaps better yet, ask|yes|no, as
> attached?

Sounds good to me.

> (set_internal_problem_cmd, show_internal_problem_cmd): New dummy
> functions.
> (add_internal_problem_command): New.
> (_initialize_utils): New.

Just to be consistent: We try to add a short description as a comment
for all new functions introduced. I think it's OK to lose the comment
in the case of the dummy functions, but it'd be nice to have a small
description for add_internal_problem_command... Other than this nit
picking, the patch looked OK to me.

--
Joel