From: Joel Brobecker <brobecker@adacore.com>
To: Pedro Alves <pedro@codesourcery.com>
Cc: gdb-patches@sourceware.org
Subject: Re: PR7580 - Command to force abort when internal error
Date: Wed, 31 Dec 2008 03:57:00 -0000 [thread overview]
Message-ID: <20081231035705.GA31595@adacore.com> (raw)
In-Reply-To: <200812291426.59784.pedro@codesourcery.com>
> I looked around for other three-state commands, and didn't find
> reusable patterns, which made me drop the idea of
> generalizing this, but there's a chance I didn't look right.
I couldn't come up with other examples where this would be useful
either. But it's always easy to factorize it if we find some later.
> I think the best is to make this an enum command with
> the three options ask|on|off, or perhaps better yet, ask|yes|no, as
> attached?
Sounds good to me.
> (set_internal_problem_cmd, show_internal_problem_cmd): New dummy
> functions.
> (add_internal_problem_command): New.
> (_initialize_utils): New.
Just to be consistent: We try to add a short description as a comment
for all new functions introduced. I think it's OK to lose the comment
in the case of the dummy functions, but it'd be nice to have a small
description for add_internal_problem_command... Other than this nit
picking, the patch looked OK to me.
--
Joel
next prev parent reply other threads:[~2008-12-31 3:57 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-29 3:35 Pedro Alves
2008-12-29 4:41 ` Joel Brobecker
2008-12-29 14:27 ` Pedro Alves
2008-12-31 3:57 ` Joel Brobecker [this message]
2009-01-07 21:59 ` Pedro Alves
2009-01-09 14:25 ` Eli Zaretskii
2009-01-09 15:33 ` Andreas Schwab
2009-01-09 18:16 ` Eli Zaretskii
2009-01-09 20:01 ` Andreas Schwab
2009-01-09 20:07 ` Eli Zaretskii
2009-01-09 20:15 ` Andreas Schwab
2009-01-09 20:26 ` Eli Zaretskii
2009-01-09 21:37 ` Andreas Schwab
2009-01-10 9:04 ` Eli Zaretskii
2009-01-25 23:19 ` Pedro Alves
2009-01-26 3:53 ` Eli Zaretskii
2009-01-26 16:27 ` Pedro Alves
2009-01-09 18:29 ` Joel Brobecker
2009-01-09 20:11 ` Eli Zaretskii
2009-01-10 6:34 ` Daniel Jacobowitz
2009-01-09 20:36 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081231035705.GA31595@adacore.com \
--to=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=pedro@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox