Re: [PATCH] Improve the fetch/store of general-purpose and floating-point PowerPC registers

[Mark Kettenis <mark.kettenis@xs4all.nl>]

> From: =?ISO-8859-1?Q?S=E9rgio?= Durigan =?ISO-8859-1?Q?J=FAnior?= <sergiodj@br.ibm.com>
> Date: Tue, 06 Jan 2009 22:43:38 -0200
> 
> Hi guys,
> 
> Here's the new version of the patch. I've made some modifications in
> order to "follow the pattern" already established in this portion of the
> code. As a side effect, the code is cleaner now since it has less #ifdef
> statements and uses control variables to decide if a ptrace flag is
> present or not.
> 
> Thanks to Luis Machado for his valuable comments regarding this.

Hi Sergio,

Do you really need those autoconf checks for PTRACE_GETREGS & friends?
I don't see things like HAVE_PTRACE_GETREGS used in the code at all,
which makes sense since you can just check whether PTRACE_GETREGS is
defined in your code.

The reason that there are some autoconf checks for PTRACE_XXX symbols
is that at some point there were some (broken) versions of glibc that
had the PTRACE_XXX symbols as enums, but not as #defines.  But those
versions predate the introduction of PTRACE_GETREGS & friends on Linux
for PowerPC by almost a decade now.

Th reason I'm somewhat concerned with adding new autoconf checks is
that on slow systems running the autoconf checks can take quite a
while.