From: Joel Brobecker <brobecker@adacore.com>
To: S?rgio Durigan J?nior <sergiodj@linux.vnet.ibm.com>
Cc: luisgpm@linux.vnet.ibm.com, gdb-patches@sourceware.org,
Mark Kettenis <mark.kettenis@xs4all.nl>
Subject: Re: [PATCH] Improve the fetch/store of general-purpose and floating-point PowerPC registers
Date: Tue, 28 Apr 2009 20:07:00 -0000 [thread overview]
Message-ID: <20090428200725.GC31821@adacore.com> (raw)
In-Reply-To: <1232558849.6328.23.camel@miki>
Sergio,
> 2009-01-21 Sergio Durigan Junior <sergiodj@linux.vnet.ibm.com>
>
> * ppc-linux-nat.c (have_ptrace_getsetregs): New variable.
> (have_ptrace_getsetfpregs): Likewise.
> fetch_all_gp_regs): New function.
> (fetch_gp_regs): New function.
> (fetch_all_fp_regs): Likewise.
> (fetch_fp_regs): New function.
> (fetch_ppc_registers): Using the new methods to fetch general-
> purpose and floating-pointer registers.
> (store_all_gp_regs): New function.
> (store_gp_regs): Likewise.
> (store_all_fp_regs): New function.
> (store_fp_regs): Likewise.
> (store_ppc_registers): Using the new methods to store general-
> purpose and floating-pointer registers.
Sorry for the delay in reviewing this. I don't know much about ptrace
except as a user, but this seems to make sense. The only request I have
is for you to write a small comment describing each new function you
introduce. The patch is OK with those changes.
PS: I assume you tested the change on 2 systems, one with the
functionality, and one without?
Thanks,
--
Joel
next prev parent reply other threads:[~2009-04-28 20:07 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-07 18:32 Sérgio Durigan Júnior
2008-10-16 20:07 ` Sérgio Durigan Júnior
2009-01-07 0:44 ` Sérgio Durigan Júnior
2009-01-07 9:56 ` Mark Kettenis
2009-01-07 16:09 ` Sérgio Durigan Júnior
2009-01-08 17:46 ` Sérgio Durigan Júnior
2009-01-09 12:26 ` Luis Machado
2009-01-21 17:28 ` Sérgio Durigan Júnior
2009-04-28 20:07 ` Joel Brobecker [this message]
2009-04-29 2:16 ` Sérgio Durigan Júnior
2009-04-29 4:05 ` Joel Brobecker
2009-05-05 18:34 ` Sérgio Durigan Júnior
2009-05-06 16:58 ` Joel Brobecker
2009-05-09 3:20 ` [PATCH] Improve the fetch/store of general-purpose andfloating-point " Sérgio Durigan Júnior
2008-11-17 23:22 ` [PATCH] Improve the fetch/store of general-purpose and floating-point " Sérgio Durigan Júnior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090428200725.GC31821@adacore.com \
--to=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=luisgpm@linux.vnet.ibm.com \
--cc=mark.kettenis@xs4all.nl \
--cc=sergiodj@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox