Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Luis Machado <luisgpm@linux.vnet.ibm.com>
To: "Sérgio Durigan Júnior" <sergiodj@linux.vnet.ibm.com>
Cc: gdb-patches@sourceware.org, Mark Kettenis <mark.kettenis@xs4all.nl>
Subject: Re: [PATCH] Improve the fetch/store of general-purpose and 	floating-point PowerPC registers
Date: Fri, 09 Jan 2009 12:26:00 -0000	[thread overview]
Message-ID: <1231503988.12849.6.camel@gargoyle> (raw)
In-Reply-To: <1231436749.2026.19.camel@miki>


On Thu, 2009-01-08 at 15:45 -0200, Sérgio Durigan Júnior wrote:
> Hey guys,
> 
> Here's the new version, without the modifications in configure.ac.
> 
> Thanks,
> 

The patch looks good to me, except for two little comments on the error
messages. Switch "write" to "set" and "status" to "register", nothing
critical, just for the sake of keeping a standard.

Else OK.

Luis


  reply	other threads:[~2009-01-09 12:26 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-07 18:32 Sérgio Durigan Júnior
2008-10-16 20:07 ` Sérgio Durigan Júnior
2009-01-07  0:44   ` Sérgio Durigan Júnior
2009-01-07  9:56     ` Mark Kettenis
2009-01-07 16:09       ` Sérgio Durigan Júnior
2009-01-08 17:46         ` Sérgio Durigan Júnior
2009-01-09 12:26           ` Luis Machado [this message]
2009-01-21 17:28             ` Sérgio Durigan Júnior
2009-04-28 20:07               ` Joel Brobecker
2009-04-29  2:16                 ` Sérgio Durigan Júnior
2009-04-29  4:05                   ` Joel Brobecker
2009-05-05 18:34                     ` Sérgio Durigan Júnior
2009-05-06 16:58                       ` Joel Brobecker
2009-05-09  3:20                         ` [PATCH] Improve the fetch/store of general-purpose andfloating-point " Sérgio Durigan Júnior
2008-11-17 23:22 ` [PATCH] Improve the fetch/store of general-purpose and floating-point " Sérgio Durigan Júnior

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1231503988.12849.6.camel@gargoyle \
    --to=luisgpm@linux.vnet.ibm.com \
    --cc=gdb-patches@sourceware.org \
    --cc=mark.kettenis@xs4all.nl \
    --cc=sergiodj@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox